Fix for #133 parsing and indexing for partial/irregular measures #256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CarlosCancino-Chacon
requested changes
Jun 6, 2023
partitura/io/importmusicxml.py
Outdated
| @@ -456,13 +456,14 @@ def _parse_parts(document, part_dict): | |||
| # shift.applied = True | |||
|
|
|||
|
|
|||
| def _handle_measure(measure_el, position, part, ongoing, doc_order): | |||
| def _handle_measure(measure_el, position, part, ongoing, doc_order, measure_counter): | |||
| # print('_handle_measure') # NOTE del | |||
| """ | |||
There was a problem hiding this comment.
Maybe it would be worthwhile to document the function a little bit, since there is a new parameter (measure_counter). It would be nice to fully document all functions at some point 😉
partitura/score.py
Outdated
|
|
||
| def __str__(self): | ||
| return f"{super().__str__()} number={self.number}" | ||
| return f"{super().__str__():16s} number={self.number} name={self.name}" |
There was a problem hiding this comment.
Why is the addition of the spaces necessary (the :16s)? Is it because of a specific formatting required by pretty_print?
CarlosCancino-Chacon
approved these changes
Jun 7, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Measure object now has 'number' and 'name' property: