Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: add a "build_unwrap" helper #508

Closed
acl-cqc opened this issue Sep 18, 2024 · 0 comments · Fixed by #534
Closed

refactor: add a "build_unwrap" helper #508

acl-cqc opened this issue Sep 18, 2024 · 0 comments · Fixed by #534
Assignees
@mark-koch

Comments

@acl-cqc
Copy link
Contributor

acl-cqc commented Sep 18, 2024

Conditional, two cases, one passes through, the other builds a panic. This pattern is showing up in a few places, we could probably do with commoning up.
@mark-koch mark-koch self-assigned this Oct 2, 2024
@mark-koch mark-koch mentioned this issue Oct 3, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 3, 2024
@mark-koch
feat: Update Hugr lowering for lists (#534)
7083760 
Closes #525 and closes #508.

* Implement `None`-swapping logic for linear list indexing similar to
arrays
* Lowering of `__length__` is still todo until
CQCL/hugr#1543 is resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mark-koch mark-koch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Update Hugr lowering for lists CQCL/guppylang
2 participants
@mark-koch @acl-cqc