Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List length op must also return the list #1543

Closed
mark-koch opened this issue Oct 2, 2024 · 0 comments · Fixed by #1547
Closed

List length op must also return the list #1543

mark-koch opened this issue Oct 2, 2024 · 0 comments · Fixed by #1547
Assignees
@mark-koch
Labels
breaking-change Changes that break semver rust Pull requests that update Rust code

Comments

@mark-koch
Copy link
Contributor

Otherwise, we can't really use it in a linear context
@mark-koch mark-koch added rust Pull requests that update Rust code breaking-change Changes that break semver labels Oct 2, 2024
This was referenced Oct 2, 2024
Merged
Merged
@mark-koch mark-koch self-assigned this Oct 3, 2024
@mark-koch mark-koch mentioned this issue Oct 3, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Oct 3, 2024
@mark-koch
fix!: Make list length op give back the list (#1547)
cf31698 
Fixes #1543.

BREAKING CHANGE: The `length` op in the std `collections` extensions now
also returns the list.
github-merge-queue bot pushed a commit to CQCL/guppylang that referenced this issue Oct 3, 2024
@mark-koch
feat: Update Hugr lowering for lists (#534)
7083760 
Closes #525 and closes #508.

* Implement `None`-swapping logic for linear list indexing similar to
arrays
* Lowering of `__length__` is still todo until
CQCL/hugr#1543 is resolved
@mark-koch mark-koch mentioned this issue Oct 17, 2024
Merged
github-merge-queue bot pushed a commit to CQCL/guppylang that referenced this issue Oct 17, 2024
@mark-koch
fix: Fix lowering of list.__len__ (#577)
c698b43 
Now that CQCL/hugr#1543 is fixed, we can use
the correct op for list length lowering
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mark-koch mark-koch

Labels
breaking-change Changes that break semver rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix!: Make list length op give back the list CQCL/hugr
1 participant
@mark-koch