Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move input array checks out of autograd example #231

Merged
merged 6 commits into from
Jan 20, 2025

Conversation

jwallwork23
Copy link
Contributor

Towards #211.
Follows #225.

This PR cuts down the amount of testing done in the autograd example. In particular, it moves the checks that input arrays aren't modified into the unit tests.

The PR also adds a missing summary for the autograd example in examples/README.md.

@jwallwork23 jwallwork23 added autograd Tasks towards the online training / automatic differentiation feature testing Related to FTorch testing labels Jan 13, 2025
@jwallwork23 jwallwork23 self-assigned this Jan 13, 2025
@jwallwork23
Copy link
Contributor Author

Just pushed a couple of commits because I realised that the cleanup subroutines weren't being used everywhere. Further, the shape checks were redundant because shape checking is already done in the assert_allclose subroutines.

Copy link
Member

@jatkinson1000 jatkinson1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jwallwork23
Been through this and the key changes make sense.
I haven't been through every change in the test_tensor_operator_overloads, but will trust that they are all OK since passing.

@jwallwork23 jwallwork23 merged commit 5522fca into main Jan 20, 2025
6 checks passed
@jwallwork23 jwallwork23 deleted the 211_autograd-update branch January 20, 2025 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autograd Tasks towards the online training / automatic differentiation feature testing Related to FTorch testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants