-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make use of pFUnit test fixtures #238
Conversation
397daeb
to
d696e4d
Compare
d696e4d
to
449846d
Compare
I recommend viewing the changes in this file offline with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this simplifies things a little in-module, and makes it easier to use.
The diff is a little hard to read (lots of changes and moved to a new file) but they seem sensible on looking through and... the tests are still passing...
Closes #236.
To follow #231 and #237 (rebased on top of those branches).
Sets up the pFUnit fixture machinery for the
test_tensor_constructors
unit tests.To do this, I needed to convert the unit tests to use modules. A benefit of doing so is that common imports and parameters could be moved to the module level. (As such, many of the lines changed are just indentations of the unit tests.)