Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make use of pFUnit test fixtures #238

Merged
merged 14 commits into from
Jan 23, 2025
Merged

Make use of pFUnit test fixtures #238

merged 14 commits into from
Jan 23, 2025

Conversation

jwallwork23
Copy link
Contributor

@jwallwork23 jwallwork23 commented Jan 14, 2025

Closes #236.
To follow #231 and #237 (rebased on top of those branches).

Sets up the pFUnit fixture machinery for the test_tensor_constructors unit tests.

To do this, I needed to convert the unit tests to use modules. A benefit of doing so is that common imports and parameters could be moved to the module level. (As such, many of the lines changed are just indentations of the unit tests.)

@jwallwork23 jwallwork23 added autograd Tasks towards the online training / automatic differentiation feature testing Related to FTorch testing labels Jan 14, 2025
@jwallwork23 jwallwork23 self-assigned this Jan 14, 2025
@jwallwork23 jwallwork23 force-pushed the 236_unit-test-fixtures branch 2 times, most recently from 397daeb to d696e4d Compare January 14, 2025 16:31
@jwallwork23 jwallwork23 force-pushed the 236_unit-test-fixtures branch from d696e4d to 449846d Compare January 20, 2025 10:58
@jwallwork23 jwallwork23 marked this pull request as ready for review January 20, 2025 11:06
@jwallwork23
Copy link
Contributor Author

I recommend viewing the changes in this file offline with git diff --word-diff. Many of the lines changed are just indentations when the modules were introduced for the tests.

Copy link
Member

@jatkinson1000 jatkinson1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this simplifies things a little in-module, and makes it easier to use.

The diff is a little hard to read (lots of changes and moved to a new file) but they seem sensible on looking through and... the tests are still passing...

@jwallwork23 jwallwork23 merged commit fc1ab25 into main Jan 23, 2025
5 checks passed
@jwallwork23 jwallwork23 deleted the 236_unit-test-fixtures branch January 23, 2025 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autograd Tasks towards the online training / automatic differentiation feature testing Related to FTorch testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use fixtures in unit tests
2 participants