Added onPreviewStarted event and fixed some issues #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 |
Output video was upside down when taken with the front camera in Portrait mode
|
Orientation fix is the same as the one in this PR: #156 |
|
Closing until a merge conflict resolution commit is in! Happy to merge is and reOpen this once available =) |
# Conflicts: # build.gradle # camerakit-core/src/main/java/com/wonderkiln/camerakit/CameraView.java # camerakit/build.gradle # camerakit/src/main/api16/com/flurgle/camerakit/Camera1.java # camerakit/src/main/java/com/flurgle/camerakit/CameraListener.java
The Event Listening system has changed so much that my old implementation no longer works. My new implementation simply adds a new Event type and dispatches that Event right after startPreview is called.
|
Sorry for the late response, it's been awhile since I've looked at this repo. I've fixed the merge conflicts and changed my implementation to work with the new Event system. |
austinkettner
added
Priority: Medium
Status: In Progress
Type: Maintenance
and removed
Status: Revision Needed
labels
Moved the event dispatch to setupPreview. Before, the event wasn't triggered when the Camera is open and closed multiple times.
|
Reviewing and will hopefully merge soon @Ninjaman494 |
|
In favor of our massive refactor, if this issue still persist please make a new PR using the refined codebase. We definitely appreciate the help though! Just limiting merge conflicts and gathering support of testing/refinement/comments/feedback on the 1.0.0 PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues: #29 #92 #68
I also added an onPreviewStarted event to CameraListener which gets called when the Camera Preview has been drawn. In my app, I need a timer to start once the camera is displayed, so I needed this event to achieve this.
This is my first pull request, so if I did something wrong I apologize.