-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v1.0.0 #318
Release v1.0.0 #318
Conversation
@developer-- @sagartrehan @p-canniff @athomaj @carrotow @ritesh94 @shoomkloom @lukaspili @mjf009 @rt-bloombees @snkashis @jondoes @rencsaridogan @virengujariya @ritesh94 @Pomis Would love your testing and feedback since you have issues in the 1.0.0 Milestone that should be resolved by this! |
Usage instructions have been added to PR notes. |
v1.0.0-beta3.11
Hi All, We are merging this and moving to a new v1.0.0-beta4 branch + develop branch to better follow Git Flow going forward. We are doubling down on wrapping up v1.0.0 soon and this is the first step, to move past this long drawn out PR and move to more incremental PRs. We will also be moving to Apache vs MIT (in our new branches) to enable Pull Requests from other users. Mentioning here as we are open to feedback before making this change and if anyone has an issue with this please comment or email us at hello [at] camerakit.io -- we are super open to any feedback here but have heard many would prefer Apache. |
Hi @austinkettner, onFrameData callback is not implemented yet? Is it on the agenda? thx |
As of now best result can be manually stopping camera on config change and then restart the camera is the best solution. for eg. - override fun onConfigurationChanged(newConfig: Configuration) { |
Hi there, in https://dl.bintray.com/camerakit/camerakit-android-snapshots/com/camerakit/camerakit/1.0.0-Snapshot/:camerakit-1.0.0-Snapshot.aar forbidden. |
This is the v1.0.0 Release of CameraKit. This release embodies over 9 months of work, with massive refactors to all parts of the codebase. This PR and changelog are not complete, yet.
Test the PR
Ready to test:
Still Coming
Dependency
Add a CameraKitView
Make sure everything looks proper with any phone rotation, while screen orientation is on auto-rotate or locked.
Open and close the app drawer and dismiss the app to make sure the camera stops and starts properly.
Basic fullscreen CameraKitView:
CameraKitView that adjusts dimenions to perfectly match previews true aspect ratio - nothing cut-off:
Square CameraKitView using
app:camera_aspectRatio
:MainActivity
Bind the CameraKitView into your activity and implement pass-through methods for
onResume()
,onPause()
, and if you want the CameraKitView to automatically handle runtime permissions,onRequestPermissionsResult(int requestCode, String[] permissions, int[] grantResults)
.