Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Geocoder improvements #1262

Closed
7 of 9 tasks
mramato opened this issue Oct 23, 2013 · 11 comments
Closed
7 of 9 tasks

Geocoder improvements #1262

mramato opened this issue Oct 23, 2013 · 11 comments

Comments

@mramato
Copy link
Contributor

mramato commented Oct 23, 2013

For the most part, these are just my ideas/suggestions left over from #1157 If you have other ideas, or feel that any of these don't belong, let me know.

  • Add event for flight completion
  • Clear Geocoder when home button is pressed
  • Add button to clear text field rather than making the user hit backspace a bunch (this is a bigger pain on mobile)
  • Detect touch support and remove hover from style sheet to fix focus issues on mobile.
  • If Bing supports it, auto-completion would be great.
  • The ability to specify a custom geocoder (with custom autocomplete suggestions).
  • Possible have multiple geocoders each offering their own suggestions to allow for domain specific searching.
  • Time based geocoding so that you can fly to an area at a particular time. (may be tricky to do)
  • Bug with lon/lat positions: Geocoder lon/lat bug #4713
@emackey
Copy link
Contributor

emackey commented Oct 23, 2013

I'm not sure we need a separate "clear" button if we implement the home-clear thing. But I like these ideas.

@mramato
Copy link
Contributor Author

mramato commented Oct 23, 2013

The main problem is if I zoom to one place, then want to zoom to another, there's no way to clear. On the desktop, it's no big deal. On touch devices, it's a pain. Chrome for Android puts an X in the awesome bar to handle this, sadly it does not do it magically for all text fields. We could could add a small X icon to the left of the magnifying glass to do the same. But we have way bigger fish to fry for now, so I'm not worried about it.

@shunter
Copy link
Contributor

shunter commented Oct 23, 2013

Also, Google Maps has an X to clear their address bar.

@mramato
Copy link
Contributor Author

mramato commented Nov 19, 2013

I've started to work on this is branch issue1262. The x in the address bar is actually the result of changing the input field to type search, which is what we should be using. Bing also has autocomplete, which should be easy to use.

@pjcozzi
Copy link
Contributor

pjcozzi commented Nov 24, 2014

For testing, it would also be nice to:

  • enter a longitude, latitude in degrees and fly to it.

@GatorScott
Copy link

It would be really nice to make time a first class citizen in this search tool.

@pjcozzi
Copy link
Contributor

pjcozzi commented Jan 23, 2015

enter a longitude, latitude in degrees and fly to it.

I needed this for testing, it is in the geocoder-fly branch.

@pjcozzi
Copy link
Contributor

pjcozzi commented Mar 5, 2015

This was requested on the forum:

@hpinkos
Copy link
Contributor

hpinkos commented May 13, 2015

"It is not recommended to use the geocoding service to power an auto complete function" forum post

The bing maps "locations" REST API doesn't have any way of asking for the top results that start with whatever you are typing, so it currently cannot be used for autocomplete.

@hpinkos
Copy link
Contributor

hpinkos commented Dec 1, 2017

Pretty much everything in this issue is addressed. I'm going to close this and open a new issue for the 1 mobile fix we still have to make.

@hpinkos hpinkos closed this as completed Dec 1, 2017
@cesium-concierge
Copy link

Congratulations on closing the issue! I found these Cesium forum links in the comments above:

https://groups.google.com/forum/#!topic/cesium-dev/Pr2vv87299I

If this issue affects any of these threads, please post a comment like the following:

The issue at #1262 has just been closed and may resolve your issue. Look for the change in the next stable release of Cesium or get it now in the master branch on GitHub https://github.com/AnalyticalGraphicsInc/cesium.


I am a bot who helps you make Cesium awesome! Contributions to my configuration are welcome.

🌍 🌎 🌏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants