Minor Geocoder improvements... #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Clear input field when the home button is used. 2. Change input to type `search` which provides an `x` button for easy clearing.
|
I noticed #1336 while looking at this, but it existed prior to this change. I hate to say it, but this should probably get a mention in |
|
I don't think there's any major new functionality here to warrant a mention in CHANGES.md. |
|
I don't think we usually restrict CHANGES.md to "major new functionality". But if you guys strongly feel there's nothing worth mentioning here I won't argue. |
|
Your three bullet points are what I think should be mentioned. :) |
|
All done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
searchwhich adds anxbutton that clears the text field (which in turn improves usability on touch screens).CC #1262