Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added IndexDatatype.fromTypedArray #10350

Merged
merged 5 commits into from
May 6, 2022
Merged

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented May 4, 2022

@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

Comment on lines +459 to +462
batchIds.typedArray = prepareVertexAttribute(
batchIds.typedArray,
"batchIds"
);
Copy link
Contributor Author

@lilleyse lilleyse May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Caught this bug in the process of adding a DeveloperError to ComponentDatatype.fromTypedArray.

@lilleyse lilleyse requested a review from IanLilleyT May 4, 2022 22:53
Copy link
Contributor

@IanLilleyT IanLilleyT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@IanLilleyT IanLilleyT merged commit 37343b4 into main May 6, 2022
@IanLilleyT IanLilleyT deleted the index-datatype-from-typed-array branch May 6, 2022 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants