Add support for MAXAR_content_geojson 3D Tiles extension #10356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @lilleyse!
Reviewers, don't forget to make sure that:
|
|
I pushed some very small code changes. Otherwise the PR looks great! I tested with a very large dataset and it rendered the lines in the correct places. |
IanLilleyT
reviewed
May 6, 2022
| * @private | ||
| */ | ||
| GeoJsonLoader.prototype.unload = function () { | ||
| this._components = undefined; |
There was a problem hiding this comment.
can unload be called before parse? Should it do this._geoJson = undefined; too?
There was a problem hiding this comment.
Never mind, after checking out GltfLoader it does a similar thing to this (unsets the json after loading finishes).
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10320.
Merge #10350 and #10351 first
This PR adds support for the
MAXAR_content_geojson3D Tiles extension which makes it possible to load vector data in the OWT Well Formed Format. This is not a replacement for Vector Tiles which still needs more planning.There are several constraints on the GeoJSON files:
2D and 3D coordinates are supported. GeoJSON properties are supported as well. All the features in the GeoJSON are batched into a single primitive to ensure good performance, and feature IDs are generated so that features are still individually pickable and styleable.
Future work:
Local sandcastle for visualizing the test models