Don't apply tonemapping for unlit material #8128
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR skips the
LINEARtoSRGB
if the material is unlit. This seemed like a simpler approach than changing theLINEARtoSRGB
function to be a no-op for unlit materials. @lilleyse let me know if you agree with this approach.This also fixes the 2nd failing unit test (from #8127) by just updating the color.
You can test that this correctly renders an unlit material with:
I used the browser's color picker to verify it is indeed the green base color.