Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AGI tileset #8132

Merged
merged 1 commit into from
Sep 3, 2019
Merged

Update AGI tileset #8132

merged 1 commit into from
Sep 3, 2019

Conversation

lilleyse
Copy link
Contributor

@lilleyse lilleyse commented Sep 3, 2019

The tileset now uses KHR_materials_unlit and will not get tonemapped anymore when HDR is disabled.

CC #8128

@lilleyse lilleyse requested a review from OmarShehata September 3, 2019 19:35
@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.
  • Works (or fails gracefully) in IE11.

@OmarShehata
Copy link
Contributor

This looks good, thanks Sean!

@OmarShehata OmarShehata merged commit 64cc4dc into master Sep 3, 2019
@OmarShehata OmarShehata deleted the agi-tileset branch September 3, 2019 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants