laudiacay/actors review F24 #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laudiacay
requested review from
connormullett,
ec2,
elmattic and
noot
as code owners
elmattic
reviewed
Dec 9, 2021
| @@ -468,6 +468,10 @@ where | |||
| ) -> Result<(ActorState, Address), ActorError> { | |||
| self.charge_gas(self.price_list().on_create_actor())?; | |||
|
|
|||
| if addr.is_bls_zero_address() && self.network_version() >= NetworkVersion::V10 { | |||
| Err(actor_error!(SysErrIllegalArgument; "cannot create the bls zero address actor"))? | |||
There was a problem hiding this comment.
ErrIllegalArgument is used by Lotus so this is a problem. Is this ok in Lotus? I would say Lotus should fix and useSysErrIllegalArgument too no?
There was a problem hiding this comment.
Return directly the error without ? to make cargo clippy happy.
noot
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes #1301
Other information and links
half of this has been merged into FVM, other half of this we're waiting on because it'll need to go outside of actors in lotus-territory.