laudiacay/actors review F24

vm/address/Cargo.toml

@@ -19,6 +19,7 @@ thiserror = "1.0"
 serde = { version = "1.0", features = ["derive"] }
 forest_json_utils = { version = "0.1", optional = true }
 once_cell = "1.7.2"
+lazy_static = "1.4.0"
 
 [features]
 json = ["forest_json_utils"]

vm/address/src/lib.rs

@@ -35,6 +35,17 @@ pub const SECP_PUB_LEN: usize = 65;
 /// BLS public key length used for validation of BLS addresses.
 pub const BLS_PUB_LEN: usize = 48;
 
+lazy_static::lazy_static! {
+    static ref BLS_ZERO_ADDR_BYTES: BLSPublicKey = {
+        let bz_addr = Address::from_str("f3yaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaby2smx7a");
+        if let Ok(Address {payload: Payload::BLS(pubkey), ..}) = bz_addr {
+            pubkey
+        } else {
+            panic!("failed to parse BLS address from provided BLS_ZERO_ADDR string")
+        }
+    };
+}
+
 /// Length of the checksum hash for string encodings.
 pub const CHECKSUM_HASH_LEN: usize = 4;
 
@@ -119,6 +130,13 @@ impl Address {
         })
     }
 
+    pub fn is_bls_zero_address(&self) -> bool {
+        match self.payload {
+            Payload::BLS(payload_bytes) => payload_bytes == *BLS_ZERO_ADDR_BYTES,
+            _ => false,
+        }
+    }
+
     /// Returns protocol for Address
     pub fn protocol(&self) -> Protocol {
         Protocol::from(self.payload)

vm/interpreter/src/default_runtime.rs

@@ -506,6 +506,12 @@ where
     ) -> Result<(ActorState, Address), ActorError> {
         self.charge_gas(self.price_list().on_create_actor())?;
 
+        if addr.is_bls_zero_address() && self.network_version() >= NetworkVersion::V10 {
+            return Err(
+                actor_error!(ErrIllegalArgument; "cannot create the bls zero address actor"),
+            );
+        }
+
         let addr_id = (*self.state)
             .borrow_mut()
             .register_new_address(addr)