Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: take ownership of command arguments #3539

Merged
merged 2 commits into from
Oct 4, 2023
Merged

chore: take ownership of command arguments #3539

merged 2 commits into from
Oct 4, 2023

Conversation

lemmih
Copy link
Contributor

@lemmih lemmih commented Oct 3, 2023 •
edited
Loading

Summary of changes

Changes introduced in this pull request:

  • taking ownership of the arguments is slightly cleaner

Reference issue to close (if applicable)

Closes

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@lemmih lemmih marked this pull request as ready for review October 3, 2023 13:57
@lemmih lemmih requested a review from a team as a code owner October 3, 2023 13:57
@lemmih lemmih requested review from ruseinov and LesnyRumcajs and removed request for a team October 3, 2023 13:57
@lemmih lemmih added this pull request to the merge queue Oct 4, 2023
Merged via the queue into main with commit d7efec8 Oct 4, 2023
@lemmih lemmih deleted the lemmih/owned-commands branch October 4, 2023 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aatifsyed aatifsyed aatifsyed approved these changes

@LesnyRumcajs LesnyRumcajs LesnyRumcajs approved these changes

@ruseinov ruseinov Awaiting requested review from ruseinov ruseinov is a code owner automatically assigned from ChainSafe/forest

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lemmih @LesnyRumcajs @aatifsyed