chore: take ownership of command arguments

src/cli/subcommands/attach_cmd.rs

@@ -355,7 +355,7 @@ impl AttachCommand {
         Ok(())
     }
 
-    pub fn run(&self, config: Config) -> anyhow::Result<()> {
+    pub fn run(self, config: Config) -> anyhow::Result<()> {
         let mut context = Context::default();
         self.setup_context(&mut context, &config.client.rpc_token);
 

src/cli/subcommands/auth_cmd.rs

@@ -40,7 +40,7 @@ fn process_perms(perm: String) -> Result<Vec<String>, JsonRpcError> {
 }
 
 impl AuthCommands {
-    pub async fn run(&self, config: Config) -> anyhow::Result<()> {
+    pub async fn run(self, config: Config) -> anyhow::Result<()> {
         match self {
             Self::CreateToken { perm } => {
                 let perm: String = perm.parse()?;

src/cli/subcommands/chain_cmd.rs

@@ -56,29 +56,29 @@ pub enum ChainCommands {
 }
 
 impl ChainCommands {
-    pub async fn run(&self, config: Config) -> anyhow::Result<()> {
+    pub async fn run(self, config: Config) -> anyhow::Result<()> {
         match self {
-            Self::Block { cid } => print_rpc_res_pretty(
-                chain_get_block(((*cid).into(),), &config.client.rpc_token).await,
-            ),
+            Self::Block { cid } => {
+                print_rpc_res_pretty(chain_get_block((cid.into(),), &config.client.rpc_token).await)
+            }
             Self::Genesis => {
                 print_rpc_res_pretty(chain_get_genesis(&config.client.rpc_token).await)
             }
             Self::Head => print_rpc_res_cids(chain_head(&config.client.rpc_token).await),
             Self::Message { cid } => print_rpc_res_pretty(
-                chain_get_message(((*cid).into(),), &config.client.rpc_token).await,
+                chain_get_message((cid.into(),), &config.client.rpc_token).await,
             ),
             Self::ReadObj { cid } => {
-                print_rpc_res(chain_read_obj(((*cid).into(),), &config.client.rpc_token).await)
+                print_rpc_res(chain_read_obj((cid.into(),), &config.client.rpc_token).await)
             }
             Self::SetHead {
                 cids,
                 epoch: Some(epoch),
                 force: no_confirm,
             } => {
-                maybe_confirm(*no_confirm, SET_HEAD_CONFIRMATION_MESSAGE)?;
+                maybe_confirm(no_confirm, SET_HEAD_CONFIRMATION_MESSAGE)?;
                 assert!(cids.is_empty(), "should be disallowed by clap");
-                tipset_by_epoch_or_offset(*epoch, &config.client.rpc_token)
+                tipset_by_epoch_or_offset(epoch, &config.client.rpc_token)
                     .and_then(|tipset_json| {
                         chain_set_head(
                             (tipset_json.into_inner().key().clone(),),
@@ -93,7 +93,7 @@ impl ChainCommands {
                 epoch: None,
                 force: no_confirm,
             } => {
-                maybe_confirm(*no_confirm, SET_HEAD_CONFIRMATION_MESSAGE)?;
+                maybe_confirm(no_confirm, SET_HEAD_CONFIRMATION_MESSAGE)?;
                 chain_set_head(
                     (TipsetKeys::from_iter(cids.clone()),),
                     &config.client.rpc_token,

src/cli/subcommands/config_cmd.rs

@@ -15,7 +15,7 @@ pub enum ConfigCommands {
 }
 
 impl ConfigCommands {
-    pub fn run<W: Write + Unpin>(&self, config: &Config, sink: &mut W) -> anyhow::Result<()> {
+    pub fn run<W: Write + Unpin>(self, config: &Config, sink: &mut W) -> anyhow::Result<()> {
         match self {
             Self::Dump => writeln!(
                 sink,

src/cli/subcommands/db_cmd.rs

@@ -28,7 +28,7 @@ pub enum DBCommands {
 }
 
 impl DBCommands {
-    pub async fn run(&self, config: &Config) -> anyhow::Result<()> {
+    pub async fn run(self, config: &Config) -> anyhow::Result<()> {
         match self {
             Self::Stats => bail_moved_cmd("db stats", "forest-tool db stats"),
             Self::GC => {

src/cli/subcommands/info_cmd.rs

@@ -161,7 +161,7 @@ impl NodeStatusInfo {
 }
 
 impl InfoCommand {
-    pub async fn run(&self, config: Config, _opts: &CliOpts) -> anyhow::Result<()> {
+    pub async fn run(self, config: Config, _opts: &CliOpts) -> anyhow::Result<()> {
         let res = tokio::try_join!(
             node_status((), &config.client.rpc_token),
             chain_head(&config.client.rpc_token),

src/cli/subcommands/net_cmd.rs

@@ -33,7 +33,7 @@ pub enum NetCommands {
 }
 
 impl NetCommands {
-    pub async fn run(&self, config: Config) -> anyhow::Result<()> {
+    pub async fn run(self, config: Config) -> anyhow::Result<()> {
         match self {
             Self::Listen => {
                 let info = net_addrs_listen((), &config.client.rpc_token)

src/cli/subcommands/send_cmd.rs

@@ -32,7 +32,7 @@ pub struct SendCommand {
 }
 
 impl SendCommand {
-    pub async fn run(&self, config: Config) -> anyhow::Result<()> {
+    pub async fn run(self, config: Config) -> anyhow::Result<()> {
         let from: Address = if let Some(from) = &self.from {
             StrictAddress::from_str(from)?.into()
         } else {

src/cli/subcommands/shutdown_cmd.rs

@@ -14,7 +14,7 @@ pub struct ShutdownCommand {
 }
 
 impl ShutdownCommand {
-    pub async fn run(&self, config: Config) -> anyhow::Result<()> {
+    pub async fn run(self, config: Config) -> anyhow::Result<()> {
         println!("Shutting down Forest node");
         if !self.force && !prompt_confirm() {
             println!("Aborted.");

src/cli/subcommands/sync_cmd.rs

@@ -40,11 +40,9 @@ pub enum SyncCommands {
 }
 
 impl SyncCommands {
-    pub async fn run(&self, config: Config) -> anyhow::Result<()> {
+    pub async fn run(self, config: Config) -> anyhow::Result<()> {
         match self {
             Self::Wait { watch } => {
-                let watch = *watch;
-
                 let ticker = Ticker::new(0.., Duration::from_secs(1));
                 let mut stdout = stdout();