Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

watermelon fix 2 #3722

Merged
merged 1 commit into from
Nov 17, 2023
Merged

watermelon fix 2 #3722

merged 1 commit into from
Nov 17, 2023

Conversation

LesnyRumcajs
Copy link
Member

@LesnyRumcajs LesnyRumcajs commented Nov 17, 2023 •
edited
Loading

Summary of changes

Changes introduced in this pull request:

  • added NV21 calibnet fix 2 support,
  • tinker with devnet check to include all fixes for calibnet,
  • updated mainnet bundle cid,
  • added the bundles on DO for mirroring.

There's a bit of duplication between the first and second fix, but it should be fine for now given we're on a tight schedule. If it happens again, we should make refactor this a bit, following the rule of three

Reference issue to close (if applicable)

Closes #3718

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@LesnyRumcajs LesnyRumcajs force-pushed the yet-another-watermelon-fix branch 3 times, most recently from ec2e96f to 43e21c7 Compare November 17, 2023 10:50
@LesnyRumcajs LesnyRumcajs force-pushed the yet-another-watermelon-fix branch from 43e21c7 to 56b5a82 Compare November 17, 2023 10:58
@LesnyRumcajs LesnyRumcajs marked this pull request as ready for review November 17, 2023 11:13
@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner November 17, 2023 11:13
@LesnyRumcajs LesnyRumcajs requested review from hanabi1224 and jdjaustin and removed request for a team November 17, 2023 11:13
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Nov 17, 2023
Merged via the queue into main with commit 470bf5f Nov 17, 2023
30 checks passed
@LesnyRumcajs LesnyRumcajs deleted the yet-another-watermelon-fix branch November 17, 2023 11:57
@LesnyRumcajs LesnyRumcajs mentioned this pull request Nov 18, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdjaustin jdjaustin jdjaustin approved these changes

@hanabi1224 hanabi1224 hanabi1224 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Calibnet Watermelon Fix 2
3 participants
@LesnyRumcajs @hanabi1224 @jdjaustin