feat: add signature verification #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobheun
force-pushed
the
feat/verify-signatures
branch
from
4347942 to
bc9facc
Compare
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
==========================================
+ Coverage 84.86% 85.65% +0.78%
==========================================
Files 8 8
Lines 489 495 +6
==========================================
+ Hits 415 424 +9
+ Misses 74 71 -3
Continue to review full report at Codecov.
|
jacobheun
force-pushed
the
feat/verify-signatures
branch
from
bc9facc to
f3badc8
Compare
jacobheun
force-pushed
the
feat/verify-signatures
branch
from
41f9c68 to
d6bd0b9
Compare
GregTheGreek
approved these changes
Jul 24, 2019
wemeetagain
approved these changes
Jul 24, 2019
fryorcraken
pushed a commit
to fryorcraken/js-libp2p-gossipsub
that referenced
this pull request
Aug 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: Older pubsub peers that do not sign messages will have their messages dropped and not forwarded. Gossipsub peers are unaffected, as message signing has been enabled since the initial release.
This adds signature verification that was introduced in the latest pubsub version libp2p/js-libp2p-pubsub#20.