Unify FilesList and SharesList #1219
Conversation
|
Your Render PR Server URL is https://files-ui-stage-pr-1219.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c3eta8qp7h3h6a5f1nh0. |
|
Your Render PR Server URL is https://storage-ui-stage-pr-1219.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c3eta9ap7h3h6a5f1o1g. |
github-actions
bot
added
the
Type: Maintenance
| @@ -301,7 +304,8 @@ const FilesList = () => { | |||
| moduleRootPath, | |||
| isSearch, | |||
| withSurvey, | |||
| bucket | |||
| bucket, | |||
| accessRole | |||
There was a problem hiding this comment.
Don't we have the accessRole inside bucket (BucketKeyPermission) now ?
There was a problem hiding this comment.
Totally, I merged dev and removed this prop
| switch(accessRole) { | ||
| case "owner": | ||
| filteredList = [ | ||
| "delete", |
There was a problem hiding this comment.
could we have something like this
const readerPermissions = ["info", "download"]
const writerPermissions = [...readerPermissions, "move", ....]
There was a problem hiding this comment.
Love the idea, check 952b03e and let me know if that's better.
| ] | ||
| if (!bulkOperations) return | ||
|
|
||
| let filteredList: FileOperation[] = [ |
There was a problem hiding this comment.
maybe fileOperations a better name ?
closes #1218