Fix bulk operations for csf buckets #1231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Render PR Server URL is https://storage-ui-stage-pr-1231.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c3hdqrk7o9q2usc87ou0. |
|
Your Render PR Server URL is https://files-ui-stage-pr-1231.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c3hdqs47o9q2usc87p60. |
github-actions
bot
added
the
Type: Bug Fix
Tbaut
commented
Jul 5, 2021
packages/files-ui/src/Components/Modules/FileBrowsers/views/FilesList.tsx
Outdated
Show resolved
Hide resolved
RyRy79261
approved these changes
Jul 5, 2021
tanmoyAtb
approved these changes
Jul 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is fix for a bug I introduced in #1219
How to reproduce, select at least 1 File in a csf bucket (normal, non shared bucket) and see that the bulk operation buttons don't show up.
edit: Github shows a complex diff but the reality is just a
if (!!permission && isShared) {that was closed too late, it should be closed right after theswitch.