Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/OP-1466: Additional Denial Letters for NYPD #372

Merged
merged 4 commits into from
Jun 8, 2018

Conversation

joelbcastillo
Copy link
Collaborator

@joelbcastillo joelbcastillo commented Jun 6, 2018

This PR adds additional denial letters as requested by the NYPD.

Letters are:

  • Denied - Collision Report
  • Denied - ICCU
  • Denied Intra-Agency
  • Denied - Refer to Agency (Blank)
    • Note: The empty line is editable. You can double click on it and fill in information as required.
  • Denied - Refer to Dept. of Corrections
  • Denied - Refer to Dept. of Transportation

Please note, due to a bug in WeasyPrint v0.42.2 some of the letters do not generate properly. Upgrading to WeasyPrint v0.42.3 resolves the issue. See WeasyPrint#609 and WeasyPrint#580

This can be done by running the following command: pip install --upgrade WeasyPrint==0.42.3

@joelbcastillo joelbcastillo added the wip Still being implemented. label Jun 6, 2018
@joelbcastillo joelbcastillo requested a review from johnyu95 June 6, 2018 22:28
@joelbcastillo joelbcastillo added ready Ready to be reviewed. and removed wip Still being implemented. labels Jun 8, 2018
Copy link
Contributor

@johnyu95 johnyu95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I made changes to the the Refer to Agency (Blank) letter. Added an extra space between "from" and the blank line. Also shortened the blank line to prevent it from pushing onto a new line in the editor.

@johnyu95 johnyu95 merged commit c02a840 into develop Jun 8, 2018
@joelbcastillo joelbcastillo deleted the feature/OP-1466 branch January 24, 2019 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready Ready to be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants