Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: pin and update some workflow actions #1145

Merged
merged 3 commits into from
May 11, 2023

Conversation

ClementTsang
Copy link
Owner

@ClementTsang ClementTsang commented May 10, 2023

Description

A description of the change, what it does, and why it was made. If relevant (such as any change that modifies the UI), please provide screenshots of the changes:

This pins the action and download-artifact actions to specific hashes. This also updates audit-check to avoid deprecation issues, and bumps setup-python and rust-toolchain.

Issue

If applicable, what issue does this address?

Closes: #

Testing

If relevant, please state how this was tested. All changes must be tested to work:

Tested most affected actions:

  • Audit: run
  • Nightly: run
  • CI: see checks
  • Clear workflow cache: run
  • Test docs: see checks
  • Codecov: see checks

Checklist

If relevant, ensure the following have been met:

  • Areas your change affects have been linted using rustfmt (cargo fmt)
  • The change has been tested and doesn't appear to cause any unintended breakage
  • Documentation has been added/updated if needed (README.md, help menu, doc pages, etc.)
  • The pull request passes the provided CI pipeline
  • There are no merge conflicts
  • If relevant, new tests were added (don't worry too much about coverage)

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (31869de) 28.88% compared to head (2d4f69b) 28.88%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1145   +/-   ##
=======================================
  Coverage   28.88%   28.88%           
=======================================
  Files          95       95           
  Lines       16286    16286           
=======================================
  Hits         4704     4704           
  Misses      11582    11582           
Flag Coverage Δ
macos-12 30.40% <ø> (ø)
ubuntu-latest 30.32% <ø> (ø)
windows-2019 30.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ClementTsang ClementTsang marked this pull request as ready for review May 11, 2023 04:42
@ClementTsang ClementTsang merged commit 2c13683 into master May 11, 2023
@ClementTsang ClementTsang deleted the pin_workflow_versions_2022-05-10 branch May 11, 2023 04:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant