-
Notifications
You must be signed in to change notification settings - Fork 255
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update GitHub CI to remove deprecated/unmaintained actions and commands #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 18.81% // Head: 18.81% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #846 +/- ##
=======================================
Coverage 18.81% 18.81%
=======================================
Files 74 74
Lines 13504 13504
=======================================
Hits 2541 2541
Misses 10963 10963 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
ClementTsang
force-pushed
the
update_outdated_ci_cmds
branch
3 times, most recently
from
October 20, 2022 10:01
8711146
to
2543972
Compare
ClementTsang
force-pushed
the
update_outdated_ci_cmds
branch
from
October 20, 2022 10:03
2543972
to
e988d1a
Compare
ClementTsang
changed the title
ci: update GitHub CI to remove deprecated commands
ci: update GitHub CI to remove deprecated/unmaintained actions and commands
Oct 20, 2022
ClementTsang
force-pushed
the
update_outdated_ci_cmds
branch
from
October 20, 2022 10:18
1ae79a0
to
7cb20d5
Compare
ClementTsang
force-pushed
the
update_outdated_ci_cmds
branch
from
October 20, 2022 10:19
7cb20d5
to
aaaa138
Compare
This was referenced Nov 11, 2022
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A description of the change and what it does. If relevant (such as any change that modifies the UI), please provide screenshots of the change:
See here (deprecated
set-output
) and here (Node 12 is deprecated) - this was causing a bunch of warnings/spam in CI/workflows.The updated CI changes are as follows:
macos-12
rather thanmacos-latest
(which pointed to 11, and was warning that it was going to move to 12)Swatinem/rust-cache
pinned to22c9328bcba27aa81a32b1bef27c7e3c78052531
(version 2.0.1)dtolnay/rust-toolchain
pinned toba37adf8f94a7d9affce79bd3baff1b9e3189c33
crazy-max/ghaction-chocolatey
pinned to90deb87d9fbf0bb2f022b91e3bf11b4441cddda5
(version 2.1.0)fkirc/skip-duplicate-actions
pinned tof11521568414503656a5af807dc3018c012552c4
(version 5.2.0)ClementTsang/cargo-action
version 0.0.3actions/upload-artifact
pinned to3cea5372237819ed00197afe530f5a7ea3e805c8
(version 3.1.0)rustsec/audit-check
pinned tobb800784d9c5b0afa352b75dae201bf2e438960a
overaction-rs/audit-check
, which is unmaintained.actions-rs/toolchain
, which I was still using in some niche cases where it worked better, as it is unmaintained and will likely break at some point unless someone takes ownership or it gets forked. I've already stopped using it for 99% of my workflows at this point, so this is probably for the better.Note some actions are out of my control and have not yet updated - tracking list:
Resolved, see ci: pin and update some workflow actions #1145rustsec/audit-check
is on Node 12.Resolved, see ci: update upload-artifact to 3.1.1 to remove set-output warnings #887upload-artifact
usesset-output
(Update theset-output
command (deprecation warning) actions/upload-artifact#351)Resolved, see ci: update action-gh-release dependency #946action-gh-release
usesset-output
(Warning: Theset-output
command is deprecated softprops/action-gh-release#268)Resolved, see ci: switch delete-tag-and-release to personal fork to avoid node16 warning #888dev-drprasad/delete-tag-and-release
uses Node 12.This also removes the GitHub workflow for macOS ARM since that is now handled by Cirrus CI.
Issue
If applicable, what issue does this address?
Closes: #
Testing
If relevant, please state how this was tested. All changes must be tested to work:
All affected workflows should be tested. This is primarily:
Checklist
If relevant, ensure the following have been met:
cargo fmt
)README.md
, help menu, etc.)