Code optimizations reported by static code analysis (2018-11-05) #26548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
[C++]
jbytheway
reviewed
Nov 6, 2018
src/faction_camp.cpp
Outdated
| units::mass carry_mass, | ||
| units::volume carry_volume ) | ||
| int talk_function::om_carry_weight_to_trips( const units::mass &mass, const units::volume &volume, | ||
| const units::mass &carry_mass, const units::volume &carry_volume ) |
There was a problem hiding this comment.
Passing units types by const reference rather than value is likely going to be a pessimization. From the ABI perspective they're effectively ints.
There was a problem hiding this comment.
Makes sense. I've rolled back these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Performance "Code optimizations reported by static code analysis"
Purpose of change
Cleanup code while increase performance.
Describe the solution
See commit messages.