Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header include cleanup (2018-11-06) #26563

Merged

Conversation

ZhilkinSerg
Copy link
Contributor

Summary

SUMMARY: None

Purpose of change

Cleanup unused and duplicate includes. Sort includes alphabetically. Modernize includes.

Additional context

Also includes changes from #26548.

@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style labels Nov 6, 2018
@ZhilkinSerg
Copy link
Contributor Author

@narc0tiq: I don't get what's wrong here - http://gorgon.narc.ro:8080/job/Cataclysm-PR-Builder/10043/console. Makefile on Jenkins differs from the one on repo? Somebody fixing MacOS builds right now?

@narc0tiq
Copy link
Contributor

narc0tiq commented Nov 6, 2018

Very possible, I just created @Veid's user -- he offered to help fix the osx builds some time ago.

@narc0tiq
Copy link
Contributor

narc0tiq commented Nov 6, 2018

I've reverted the change, so Jenkins rebuild.

@Veid
Copy link
Contributor

Veid commented Nov 6, 2018

@ZhilkinSerg @narc0tiq Yes, that was me. I was trying to test a fix without a lot of fuss. I'm about to create a new pull request to fix the crashing macOS builds.

EDIT:
Pull request: #26564

@narc0tiq
Copy link
Contributor

narc0tiq commented Nov 6, 2018

@Veid No worries, we'll fix it. Jenkins might be spotty for a few minutes, though, as I'm running package updates.

@ZhilkinSerg ZhilkinSerg force-pushed the header-cleanup-2018-11-06 branch from 4d0d12c to 02635a9 Compare November 7, 2018 00:56
@ZhilkinSerg
Copy link
Contributor Author

Thanks, @narc0tiq! Can you please also check this when you have some spare time - http://gorgon.narc.ro:8080/job/Cataclysm-Matrix/8128/console?

@Veid
Copy link
Contributor

Veid commented Nov 7, 2018

@ZhilkinSerg I've fixed this -- some incorrect permissions from when I was working earlier.

@ZhilkinSerg
Copy link
Contributor Author

Thanks.

@Rivet-the-Zombie Rivet-the-Zombie merged commit b6346ea into CleverRaven:master Nov 7, 2018
@ZhilkinSerg ZhilkinSerg deleted the header-cleanup-2018-11-06 branch November 8, 2018 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Code: Infrastructure / Style / Static Analysis Code internal infrastructure and style
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants