-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Header include cleanup (2018-11-06) #26563
Header include cleanup (2018-11-06) #26563
Conversation
@narc0tiq: I don't get what's wrong here - http://gorgon.narc.ro:8080/job/Cataclysm-PR-Builder/10043/console. Makefile on Jenkins differs from the one on repo? Somebody fixing MacOS builds right now? |
Very possible, I just created @Veid's user -- he offered to help fix the osx builds some time ago. |
I've reverted the change, so Jenkins rebuild. |
@ZhilkinSerg @narc0tiq Yes, that was me. I was trying to test a fix without a lot of fuss. I'm about to create a new pull request to fix the crashing macOS builds. EDIT: |
@Veid No worries, we'll fix it. Jenkins might be spotty for a few minutes, though, as I'm running package updates. |
4d0d12c
to
02635a9
Compare
Thanks, @narc0tiq! Can you please also check this when you have some spare time - http://gorgon.narc.ro:8080/job/Cataclysm-Matrix/8128/console? |
@ZhilkinSerg I've fixed this -- some incorrect permissions from when I was working earlier. |
Thanks. |
Summary
SUMMARY: None
Purpose of change
Cleanup unused and duplicate includes. Sort includes alphabetically. Modernize includes.
Additional context
Also includes changes from #26548.