Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blazemod Mini-PR: Modernises blob_turret_mount and adds blob_turret abstract #39670

Merged

Conversation

Soup-de-Loop
Copy link
Contributor

Summary

SUMMARY: Mods "Modernises blob_turret_mount and adds blob_turret abstract"

Purpose of change

This is the sixth PR in bringing the changes in #37497 about, by breaking each change into small parts that are easier to skim and understand.

Describe the solution

Changes the blob_turret_mount to reflect the vanilla turret_mount by adding missing fields, re-arranging their order and tweaking a thing or two (which should be looked at later). Also adds a new abstract for the blob_turret to mirror functionality of the vanilla turret which will be used to standardise blob turrets and lower the number of lines used for the same effect.

Testing

Straightforward changes drawn from #37497, probably might work for now but its compatibility will be broken again when ID's are changed.

Additional context

More PR's to come, consider incomplete by itself, part of a whole.

groundwork for blob_turret modernisation
@ZhilkinSerg ZhilkinSerg added [JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Vehicles Vehicles, parts, mechanics & interactions labels Apr 18, 2020
@ZhilkinSerg ZhilkinSerg merged commit 442c34d into CleverRaven:master Apr 18, 2020
@Soup-de-Loop Soup-de-Loop deleted the soupdeloop-blazemod-PR6 branch April 30, 2020 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JSON] Changes (can be) made in JSON Mods Issues related to mods or modding Vehicles Vehicles, parts, mechanics & interactions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants