Blazemod Mini-PR: Streamlines blob turrets with modern json techniques #39672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Put into draft status due to being dependent on #39670. |
ZhilkinSerg
added
[JSON]
Soup-de-Loop
force-pushed
the
soupdeloop-blazemod-PR7
branch
from
4ea4a4e to
62c5ef6
Compare
|
Rebase force pushed now that dependency PR #39670 has been committed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Mods "Streamlines blob turrets with modern json techniques"Purpose of change
This is the seventh PR in bringing the changes in #37497 about, by breaking each change into small parts that are easier to skim and understand.
Describe the solution
Using a blob turret template such as vanilla turrets do with the
turretvehiclepart, entries that all or most blob turrets have in common can be echoed using theblob_turretabstract as a template. This reduces the amount of additional fields needed, while still allowing customizability as in the case of the shredder-like parts. Does not modernise string names, which will be in another PR.Testing
Straightforward changes drawn from #37497, probably might work for now but its compatibility will be broken again when ID's are changed.
Additional context
More PR's to come, consider incomplete by itself, part of a whole.