Add and fix Aqua tests #785
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It may be that we want to include type parameters in |
|
bors try |
|
bors try- |
charleskawczynski
force-pushed
the
ck/aqua
branch
2 times, most recently
from
37051bf to
797e39e
Compare
|
bors try |
tryBuild failed: |
|
bors try |
tryBuild failed: |
charleskawczynski
force-pushed
the
ck/aqua
branch
from
c43d79c to
7b2fc36
Compare
|
bors try |
tryBuild failed: |
charleskawczynski
force-pushed
the
ck/aqua
branch
from
7b2fc36 to
717f452
Compare
|
bors try |
Fix Aqua tests Add compat entry for Aqua Fix dispatching
|
I think this is ready to go, cc @simonbyrne. Going to squash now. |
charleskawczynski
force-pushed
the
ck/aqua
branch
from
717f452 to
f23fb10
Compare
|
All these changes look safe to me. Merging. cc @simonbyrne. |
|
bors r+ |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Aqua tests, specifically,
Aqua.test_unbound_args(ClimaCore), which tests that no functions defined in ClimaCore run into this julia issue.Adding this test revealed 9 instances of this issue, and the PR also includes fixes so that we pass all of the tests.