Ry 77 change review status #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
circlegov
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#77 ℹ️ Issue
Closes #77
📝 Description
Changes made to reflect if an application has been reviewed by checking for reviews for an application and adjust the application step if applicable
Changes made to code:
Added an if statement and sets a variable accordingly to check if an application has any reviews and passes that through to reflect the information in toGetAllApplicationResponseDTO and toGetApplicationResponseDTO
✔️ Verification
Added review to a dummy application to verify that it changes to reviewed when a review has been made.
And deleted review to make sure that it returns to submitted when there are no reviews
🏕️ (Optional) Future Work / Notes