Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: return data samples as pandas.DataFrame #146

Closed
wants to merge 2 commits into from
Closed

feat: return data samples as pandas.DataFrame #146

wants to merge 2 commits into from

Conversation

redeboer
Copy link
Member

@redeboer redeboer commented Nov 9, 2020

@spflueger Here's an attempt to return pandas.DataFrame instead of a numpy.array. Works fine for the tests, but I get in trouble with the IntensityTF call. This is not tested, so we may want to write some tests for generate_data first.

@redeboer redeboer added 🔨 Maintenance Maintenance and upkeep improvements 💡 Enhancement labels Nov 9, 2020
@redeboer redeboer requested a review from spflueger November 9, 2020 16:03
@redeboer redeboer self-assigned this Nov 9, 2020
@redeboer redeboer changed the title Pandas.data frame feat: return data samples as pandas.DataFrame Nov 9, 2020
@redeboer redeboer force-pushed the epic/23-data-module branch from c775f5b to 68e2a21 Compare November 11, 2020 14:34
@redeboer redeboer marked this pull request as draft November 11, 2020 15:11
@redeboer redeboer added this to the Release 0.2.0 milestone Nov 19, 2020
@redeboer redeboer removed the request for review from spflueger February 10, 2021 09:53
@redeboer redeboer closed this Mar 12, 2021
@redeboer redeboer deleted the branch ComPWA:epic/23-data-module March 12, 2021 16:39
@redeboer redeboer deleted the pandas.DataFrame branch March 12, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔨 Maintenance Maintenance and upkeep improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant