refactor!: implement Model interface to lambdify Callables #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In HelicityKinematics calculate the non squared invariant masses instead. Currently calculated the squared values. The reasoning is to simplify usage and potentially have small performance gains in the evaluation.
This completely describes the calculation of an amplitude model from the four momentum input to the intensity value output. It is based on sympy expression and symbols.
Note: includes change in estimator interface.
Note: currently only when choosing the jax backend, gradients are supported.
Allow complex valued parameters to be fitted by defining an adapter that flattens the complex to a pair of floats and the reverse operation unflattening.
Use jax.jit in lambdify when using the jax backend.
Removes the need for SubSystem, ParticleReactionInfo, etc.
This reverts commit ce546da.
This was referenced Mar 12, 2021
redeboer
approved these changes
Mar 12, 2021
This reverts commit 97cad34.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several breaking changes
All physics (
amplitude,dynamics,kinematics) has been moved to theexpertsystem, where the amplitude model is now formulated in terms of SymPy. TensorWaves is now more abstract: the core has become a templateModelclass that can be 'lambdified' into aFunctionwith different computational backends. Theesimatoranddatamodules are still there, but changed slightly because of the intermediateModellayer.Since the responsibilities of
tensorwaveshave changed quite a bit and much code has been removed, the module structure has been changed drastically as well. The example workflow notebooks therefore changed as well.See also: ComPWA/expertsystem#454
Reopened from #203
This PR also closes several issues, because the physics has been 'abstracted out' to the
expertsystemthrough theModelinterface.#184(will be illustrated in a notebook in a follow-up PR)Closes #172
Closes #162
Closes #146
Closes #70
Closes #64
Closes #45
Closes #37