AdvancedCollectionView: Use generic arguments if possible to get type of elements in list #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @lhak, can you add a unit test for this scenario so we can ensure we don't regress in the future? |
|
I have added a test that reproduces the crash without the code changes |
* Init * Remove other files * Adding TreeView sample * XAML styler * Adding TreeView icon * XAML styler * Some more XAML styling * Addressing feedback * XAML styler * xaml styler * Fix for mismatch in WUX/MUXC TreeViewItem type in Sample Caused unhelpful exception when running in UWP * Fix test, sample * Include Controls in PackageId --------- Co-authored-by: michael-hawker <[email protected]> Co-authored-by: Arlo Godfrey <[email protected]>
* Init * Fixing namespaces * resolving platform diferences * Fix ref * Working sample * Update TokenizingTextBoxCustomSample.xaml * Design fixes * Visual updates * Update tooling * More changes * Updating samples and tests * Adding SampleEmailType * Remove unused files * Sample improvements * Uno improvements * Remove local WrapPanel * Revert "Remove local WrapPanel" This reverts commit f982bca. * Fix test * Remove local WrapPanel * Remove unused code from sample * Adding icons * Update components/TokenizingTextBox/src/CommunityToolkit.WinUI.Controls.TokenizingTextBox.csproj * Update components/TokenizingTextBox/src/InterspersedObservableCollection.cs Co-authored-by: Michael Hawker MSFT (XAML Llama) <[email protected]> * Removed extraneous information from TokenizingTextBox sample docs * Get dispatcher queue from constructor --------- Co-authored-by: Arlo <[email protected]> Co-authored-by: Michael Hawker MSFT (XAML Llama) <[email protected]>
…ontrols.LayoutTransformControl.csproj
…FrameworkElementExtensions.RelativeAncestor to FrameworkElement over DependencyObject Code scoped to FrameworkElement in callback, so doesn't work with just DependencyObject as-is.
* Port over content for StackedNotificationBehavior from Labs to Behaviors component * Make notifications cycle vs. be completely random so easier to see new notification in sample * Add more complete documentation and examples on Migrating from prior Toolkit control Adds additional `Show` methods to act as backward compatibile helpers. * Add IconSource to Notification for StackedNotificationsBehavior * Add an initial test for the StackedNotifications Behavior * Make Title and Severity work like Overrides, so parent InfoBar can have constant values for Notifications Added test for override scenario * Add test for Duration of StackedNoticationsBehavior * Added test for cancelling the close of a notification from the InfoBar Closing event Added a Clear method to clear all notifications on the StackedNotificationsBehavior Added more migration notes * Fix warnings about possible null reference assignment * Missed MUXC prefix * Updating icon * Minor sample tweaks * Update Build Script to emit more diagnostics for diagnosing test issues * Fix potential issue with Timer still activating after clean-up of StackedNotificationsBehavior * Add some more automatic analysis and try ignoring a specific test... --------- Co-authored-by: Vincent Gromfeld <[email protected]> Co-authored-by: Niels Laute <[email protected]>
…and analyze dorny/paths-filter only works on detecting changes to git files not untracked files Add Blame to test runner and upload of sequence file
… all examples show lowercase? Also, add PackageIconUrl back as acceptable to have both for backwards compat
… it's just random based on number of tests run...) Need to comment out as Ignore ignored... see CommunityToolkit/Tooling-Windows-Submodule#121 Related to investigation, see info in actions/runner-images#7937
See if this helps with `PackageIcon`
Co-authored-by: Niels Laute <[email protected]>
* Fixed build errors caused by .NET 7 upgrade * Updated tooling pointer Update tooling to latest upgrade/net7 * Bump uno-check * Skip vswinworkloads * Update Build Script to support Pull Request Packages Again Cleaned up some logic for diagnostic builds as well so we have a single build command * Update tooling to use maccatalyst * Fix for net7.0-maccatalyst, use dotnet 7.0.100 * Update tooling, additional net7-mobile error suppression * Update tooling: More error suppression for net7 mobile * Fixed invalid symbol references in comments * Update editorconfig * Update editorconfig * Update logic for Versioning of Build and ensure to pass to Packing Script * Use net7.0-android33.0 instead of net7.0-android * Fix and un-suppress CS1574 errors * Remove suppression of CS1587 * Update tooling pointer * Fixed remaining build errors * Update tooling to latest main * Suppress CS1587 * Move platfiorm conditionals to using statements * Fix issue with XML comment for StackedNotificationsBehavior 2023-08-17T20:08:53.7233918Z 5>D:\a\Windows\Windows\components\Behaviors\src\Notification\StackedNotificationsBehavior.cs(16,70): error CS1574: XML comment has cref attribute 'InfoBar' that could not be resolved --------- Co-authored-by: michael-hawker <[email protected]>
* Enabled WinUI 3 support for BackdropSourceExtension * Added EffectAnimations to Media component, build fixes * Update tooling to include CommunityToolkit/Tooling-Windows-Submodule#102 * Consolidate custom options panes * Added CrossFadeEffectAnimationSample * Added ExposureEffectAnimation sample * Cleanup / style tweaks * Add HueRotationEffectAnimationSample, adjust animation timings * Added remaining effect animation samples. OpactiyEffectAnimation not working. * Ran XAML styler * Disabled OpacityEffectAnimation * Set tooling to latest main * Updated tooling pointer * Fix build errors * Changing assets * Adding new icon * Minor sample tweaks * Use JPG instead of PNG --------- Co-authored-by: Niels Laute <[email protected]> Co-authored-by: Michael Hawker MSFT (XAML Llama) <[email protected]>
* Adding NavigateToUriBehavior * Address feedback * Comment tweak
Add some initial outline for next release job (not sure how we want to test this one...)
… and WinUI 3 Jobs
… for pack command
Update Tooling Module Semver regex tested locally
Arlodotexe
approved these changes
Aug 23, 2023
|
@lhak noticed you submitted this PR directly from the That also allows you to keep a clean copy of @Arlodotexe is cherry-picking your commits quick to a new branch so we can get this merged in, as the changes are good. You'll still receive authorship, but then we'll close this PR out. He'll link to the new PR when it's up. Thanks for your contribution! 🦙❤ |
|
Carried over to #182 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #78