This repository has been archived by the owner on Jan 3, 2019. It is now read-only.
Fix issue #138 #164
Merged
Fix issue #138 #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 11, 2014
|
All the commits by @pumazi look good to me. |
|
I would love to merge this as is, but hate the term TriStateBoolean. How about ... Trinary http://en.wikipedia.org/wiki/Three-valued_logic |
|
actually, Trinary, not Trivalent |
This corrects and issue where if the has_accepted value was None, it would change the value to True.
This corrects and issue where a revision would not sync up previously accepted values into the newly created content.
This is necessary for when we don't fetch the latest updated content from storage before sending the content to the user.
This is further verification of the roles sync with publishing when creating a revision.
This will sync the license acceptance with publishing when a revision is created.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Along with addressing #138, this also includes logic to always include the
has_accepted(or as webview knows ithasAccepted) in all role entries, not just those that have been rejected or accepted, but also those that are in an unknown state (see also the schemata change that adds theTriStateBooleanschema type).