This repository has been archived by the owner on Apr 5, 2024. It is now read-only.
[ES-100] refactor CLI option name from disabled to enabled #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sally MacFarlane <[email protected]>
usmansaleem
reviewed
Feb 13, 2020
...ance-tests/src/test/java/tech/pegasys/ethsigner/tests/dsl/signer/EthSignerProcessRunner.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
rain-on
added
TeamGroot
Signed-off-by: Sally MacFarlane <[email protected]>
rain-on
reviewed
Feb 17, 2020
...mandline/src/main/java/tech/pegasys/ethsigner/config/tls/client/PicoCliClientTlsOptions.java
Show resolved
Hide resolved
...mandline/src/main/java/tech/pegasys/ethsigner/config/tls/client/PicoCliClientTlsOptions.java
Outdated
Show resolved
Hide resolved
...mandline/src/main/java/tech/pegasys/ethsigner/config/tls/client/PicoCliClientTlsOptions.java
Outdated
Show resolved
Hide resolved
...mandline/src/main/java/tech/pegasys/ethsigner/config/tls/client/PicoCliClientTlsOptions.java
Show resolved
Hide resolved
Signed-off-by: Sally MacFarlane <[email protected]>
usmansaleem
reviewed
Feb 17, 2020
...mandline/src/main/java/tech/pegasys/ethsigner/config/tls/client/PicoCliClientTlsOptions.java
Show resolved
Hide resolved
usmansaleem
reviewed
Feb 17, 2020
...mandline/src/main/java/tech/pegasys/ethsigner/config/tls/client/PicoCliClientTlsOptions.java
Outdated
Show resolved
Hide resolved
usmansaleem
reviewed
Feb 17, 2020
ethsigner/commandline/src/main/java/tech/pegasys/ethsigner/CommandlineParser.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
Signed-off-by: Sally MacFarlane <[email protected]>
usmansaleem
reviewed
Feb 17, 2020
| @@ -57,6 +57,8 @@ public String getCommandName() { | |||
|
|
|||
| @Override | |||
| public void run() { | |||
| // parseArgs ensures all args are populated and can then be validated prior to any setup | |||
There was a problem hiding this comment.
the comment seems bit misleading here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match conventions used elsewhere, change --downstream-http-tls-ca-auth-disabled to --downstream-http-tls-ca-auth-enabled
Signed-off-by: Sally MacFarlane [email protected]