Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: frontend.Compile with PLONK became too slow #155

Closed
gbotrel opened this issue Oct 26, 2021 · 0 comments
Closed

perf: frontend.Compile with PLONK became too slow #155

gbotrel opened this issue Oct 26, 2021 · 0 comments
Assignees
Milestone

Comments

@gbotrel
Copy link
Collaborator

gbotrel commented Oct 26, 2021

This #153 fixed an issue where we would split linear expression from R1C into duplicate plonk constraints. But the perf impact is non-negligible.

Compilation, on some circuits (the ones with large linear expressions like std/algebra/scalar mul or std/groth16) CPU time will be spend mostly (95% +) in:
split -> cs.coeffID(...) divideLinearExpression computeGCD and big.Int mallocs...

@gbotrel gbotrel added this to the v0.6.0 milestone Oct 26, 2021
gbotrel added a commit that referenced this issue Nov 3, 2021
fixes #155 slow plonk compile, fixes #163 detects unconstrained inputs
@gbotrel gbotrel closed this as completed in 0da1f52 Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants