Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensures frontend.Compile picks up unconstrained inputs #163

Closed
gbotrel opened this issue Nov 1, 2021 · 0 comments
Closed

Ensures frontend.Compile picks up unconstrained inputs #163

gbotrel opened this issue Nov 1, 2021 · 0 comments
Labels
bug Something isn't working
Milestone

Comments

@gbotrel
Copy link
Collaborator

gbotrel commented Nov 1, 2021

Example: circuit defines a public input A, and overwrites it in the Define with something else.

A is never constrained, resulting in infinity points in the VerifyingKey (groth16), hence accepting all inputs.

gnark frontend should catch these programming mistake, if possible in the frontend.

@gbotrel gbotrel added the bug Something isn't working label Nov 1, 2021
@gbotrel gbotrel added this to the v0.6.0 milestone Nov 1, 2021
gbotrel added a commit that referenced this issue Nov 3, 2021
fixes #155 slow plonk compile, fixes #163 detects unconstrained inputs
@gbotrel gbotrel closed this as completed in 0bb9828 Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant