Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/plonk memory optim #1395

Merged
merged 13 commits into from
Jan 17, 2025
Merged

Feat/plonk memory optim #1395

merged 13 commits into from
Jan 17, 2025

Conversation

ThomasPiellard
Copy link
Collaborator

Description

I deleted to useless vectors storing the identity polynomial and the Lagrange polynomial in the plonk prover. It saves memory and also 16 FFTs.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How has this been tested?

Same plonk test suite

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@ThomasPiellard ThomasPiellard merged commit 3a407c1 into master Jan 17, 2025
5 checks passed
@ThomasPiellard ThomasPiellard deleted the feat/plonk_memory_optim branch January 17, 2025 10:14
Wollac added a commit to risc0/gnark that referenced this pull request Jan 31, 2025
* Feat/plonk memory optim (Consensys#1395)

* perf: `PairingCheck` for BN254, BLS12-381, BLS12-377 and BW6-761 (Consensys#1365)

Co-authored-by: Ivo Kubjas <[email protected]>

* fix: add G2 membership check for constant points (Consensys#1397)

* fix: stashed typo fixes for v0.12 (Consensys#1398)

Signed-off-by: oliveredget <[email protected]>
Signed-off-by: dashangcun <[email protected]>
Signed-off-by: zhuhaicity <[email protected]>
Signed-off-by: hidewrong <[email protected]>
Co-authored-by: oliveredget <[email protected]>
Co-authored-by: dashangcun <[email protected]>
Co-authored-by: ZhuHaiCheng <[email protected]>
Co-authored-by: hidewrong <[email protected]>
Co-authored-by: VolodymyrBg <[email protected]>

* release: v0.12.0 (Consensys#1399)

---------

Signed-off-by: oliveredget <[email protected]>
Signed-off-by: dashangcun <[email protected]>
Signed-off-by: zhuhaicity <[email protected]>
Signed-off-by: hidewrong <[email protected]>
Co-authored-by: ThomasPiellard <[email protected]>
Co-authored-by: Youssef El Housni <[email protected]>
Co-authored-by: Ivo Kubjas <[email protected]>
Co-authored-by: oliveredget <[email protected]>
Co-authored-by: dashangcun <[email protected]>
Co-authored-by: ZhuHaiCheng <[email protected]>
Co-authored-by: hidewrong <[email protected]>
Co-authored-by: VolodymyrBg <[email protected]>
lucasmenendez pushed a commit to lucasmenendez/gnark that referenced this pull request Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants