fix: add G2 membership check for constant points #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThomasPiellard
approved these changes
Jan 21, 2025
Wollac
added a commit
to risc0/gnark
that referenced
this pull request
Jan 31, 2025
* Feat/plonk memory optim (Consensys#1395) * perf: `PairingCheck` for BN254, BLS12-381, BLS12-377 and BW6-761 (Consensys#1365) Co-authored-by: Ivo Kubjas <[email protected]> * fix: add G2 membership check for constant points (Consensys#1397) * fix: stashed typo fixes for v0.12 (Consensys#1398) Signed-off-by: oliveredget <[email protected]> Signed-off-by: dashangcun <[email protected]> Signed-off-by: zhuhaicity <[email protected]> Signed-off-by: hidewrong <[email protected]> Co-authored-by: oliveredget <[email protected]> Co-authored-by: dashangcun <[email protected]> Co-authored-by: ZhuHaiCheng <[email protected]> Co-authored-by: hidewrong <[email protected]> Co-authored-by: VolodymyrBg <[email protected]> * release: v0.12.0 (Consensys#1399) --------- Signed-off-by: oliveredget <[email protected]> Signed-off-by: dashangcun <[email protected]> Signed-off-by: zhuhaicity <[email protected]> Signed-off-by: hidewrong <[email protected]> Co-authored-by: ThomasPiellard <[email protected]> Co-authored-by: Youssef El Housni <[email protected]> Co-authored-by: Ivo Kubjas <[email protected]> Co-authored-by: oliveredget <[email protected]> Co-authored-by: dashangcun <[email protected]> Co-authored-by: ZhuHaiCheng <[email protected]> Co-authored-by: hidewrong <[email protected]> Co-authored-by: VolodymyrBg <[email protected]>
lucasmenendez
pushed a commit
to lucasmenendez/gnark
that referenced
this pull request
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
PR #1387 introduced implicit G2 membership check during lines computation. This allows to avoid separate G2 membership test.
However, when the G2 points is given as a constant (i.e. embedded in the circuit description), for example in recursive proof verification, then we don't explicitly check the G2 membership for the constant point. This PR adds this check.
Type of change
How has this been tested?
Existing tests pass
Checklist:
golangci-lintdoes not output errors locally