Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cw4 group list members by weight #272

Closed
wants to merge 11 commits into from
Closed

Cw4 group list members by weight #272

wants to merge 11 commits into from

Conversation

maurolacy
Copy link
Contributor

@maurolacy maurolacy commented Apr 15, 2021 •
edited
Loading

Uses IndexedSnapshotMap to do the list_members query sorted by weight.

Continuation of #255. Uses #271.

@maurolacy maurolacy requested a review from ethanfrey April 15, 2021 20:22
@maurolacy maurolacy self-assigned this Apr 15, 2021
@maurolacy maurolacy mentioned this pull request Apr 15, 2021
Merged
@maurolacy maurolacy changed the base branch from master to indexed-snapshot-map April 15, 2021 20:55
@maurolacy maurolacy force-pushed the cw4-list-members-by-weight branch 3 times, most recently from 5ba6368 to b9ef574 Compare April 16, 2021 08:42
@maurolacy maurolacy marked this pull request as draft April 16, 2021 08:56
ethanfrey
ethanfrey reviewed Apr 16, 2021
View reviewed changes
Copy link
Member

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice start. Added some comments

contracts/cw4-group/src/contract.rs Outdated Show resolved Hide resolved
contracts/cw4-group/src/contract.rs Outdated Show resolved Hide resolved
contracts/cw4-group/src/contract.rs Outdated Show resolved Hide resolved
Base automatically changed from indexed-snapshot-map to master April 16, 2021 10:40
@maurolacy maurolacy force-pushed the cw4-list-members-by-weight branch from 6cb0cc8 to 4a28fe5 Compare April 16, 2021 10:41
@maurolacy maurolacy marked this pull request as ready for review April 17, 2021 09:19
@maurolacy maurolacy mentioned this pull request Apr 17, 2021
Closed
@maurolacy maurolacy changed the title Cw4 list members by weight Cw4 group list members by weight Apr 17, 2021
This was referenced Apr 17, 2021
Merged
Closed
@maurolacy maurolacy force-pushed the cw4-list-members-by-weight branch from 79a4512 to 51caf52 Compare April 19, 2021 10:01
@maurolacy
Copy link
Contributor Author

Closed in favour of adding this functionality to tgrade. See tgrade issue #27 and pull #34.

@maurolacy maurolacy closed this Apr 20, 2021
@ethanfrey ethanfrey deleted the cw4-list-members-by-weight branch August 26, 2021 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey left review comments

Assignees

@maurolacy maurolacy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maurolacy @ethanfrey