Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tg4 spec and uses #34

Merged
merged 43 commits into from
Apr 21, 2021
Merged

Tg4 spec and uses #34

merged 43 commits into from
Apr 21, 2021

Conversation

maurolacy
Copy link
Contributor

Closes #27.

@maurolacy maurolacy self-assigned this Apr 20, 2021
This was referenced Apr 20, 2021
Closed
Closed
Closed
maurolacy added 26 commits April 20, 2021 19:37
@maurolacy
Copy cw4 spec files
e6ad560
@maurolacy
Rename package to tg4
c9dab7a
@maurolacy
Update README
57f77ae
@maurolacy
Rename Cw4 to Tg4
b4d718c
@maurolacy
Update cargo lock file
3985685
@maurolacy
Update schema
5e2b9af
@maurolacy
Copy cw4-group contract files
38b4966
@maurolacy
Rename contract to tg4-group
d05cf8d
@maurolacy
Update README
73f561e
@maurolacy
Add cargo config
9a49e9f
@maurolacy
Rename Cw4 to Tg4
3705e53
@maurolacy
Update cargo lock file
a41fe0b
@maurolacy
Add schema
3ef2af7
@maurolacy
Copy cw4-stake contract files
6012b06
@maurolacy
Rename contract to tg4-stake
eaae119
@maurolacy
Update README
21db125
@maurolacy
Add cargo config
1e18844
@maurolacy
Fix Cargo.toml
ef9dad2
@maurolacy
Rename Cw4 to Tg4
b30261d
@maurolacy
Update cargo lock file
1cf611d
@maurolacy
Update schema
c05d19f
@maurolacy
Add ListMembersByWeight to tg4 spec
ed25acf
@maurolacy
Add members() IndexedSnapshotMap
dc96183
@maurolacy
Add list_members_by_weight method / msg
40f47fd
@maurolacy
Add list_members() pagination / limits tests
df046cc
@maurolacy
Add list_members_by_weight() pagination / limits tests
b0fb05a
ethanfrey
ethanfrey reviewed Apr 20, 2021
View reviewed changes
Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the spec and one change request.

I will review the contracts shortly.

packages/tg4/src/helpers.rs Show resolved Hide resolved
packages/tg4/src/query.rs Outdated Show resolved Hide resolved
ethanfrey
ethanfrey reviewed Apr 20, 2021
View reviewed changes
Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. 2 requests:

  • Change the pagination type in the ListMembersByWeight query
  • Explain why we choose MultiIndex over UniqueIndex (or visa versa) in the members() Map. (You understand storage-plus quite well and this can be elucidating for future readers.

contracts/tg4-group/src/contract.rs Show resolved Hide resolved
contracts/tg4-group/src/contract.rs Outdated Show resolved Hide resolved
contracts/tg4-group/src/msg.rs Outdated Show resolved Hide resolved
contracts/tg4-group/src/state.rs Show resolved Hide resolved
contracts/tg4-stake/src/contract.rs Show resolved Hide resolved
contracts/tg4-stake/src/msg.rs Outdated Show resolved Hide resolved
contracts/tg4-stake/src/state.rs Show resolved Hide resolved
ethanfrey
ethanfrey reviewed Apr 20, 2021
View reviewed changes
Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I saw the valset changes.
Looks good. Made one more suggested enhancement

contracts/tgrade-valset/src/contract.rs Show resolved Hide resolved
ethanfrey
ethanfrey approved these changes Apr 21, 2021
View reviewed changes
Copy link
Contributor

@ethanfrey ethanfrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these fixes - API, docs, and optimization.
Looking good.

contracts/tg4-group/src/state.rs Show resolved Hide resolved
@ethanfrey ethanfrey merged commit 6c42da5 into main Apr 21, 2021
@ethanfrey ethanfrey deleted the tg4-spec branch April 21, 2021 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ethanfrey ethanfrey ethanfrey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tg4 to extend cw4 and implement
2 participants
@maurolacy @ethanfrey