Upgrade to MUI v5 - rebased from client-deps-2 upgrade #4391

ekowidianto · 2022-03-03T09:53:43Z

Rebased upgrade based on mui/material-ui#4363

Tests failed here since @material-ui/pickers require MUI v4. Refer to unrebased branch (above) for all passed test cases.

Related to mui/material-ui#4363

hound · 2022-03-03T09:53:52Z

...essment/question/programming/containers/ProgrammingQuestionForm/ProgrammingQuestionForm.scss

-  margin-bottom: 1em;
-  margin-top: 1em;
+  margin-bottom: 1em !important;
+  margin-top: 1em !important;


!important should not be used

hound · 2022-03-03T09:53:52Z

...essment/question/programming/containers/ProgrammingQuestionForm/ProgrammingQuestionForm.scss

@@ -68,6 +67,6 @@
 }

 .submitButton {
-  margin-bottom: 1em;
-  margin-top: 1em;
+  margin-bottom: 1em !important;


!important should not be used

hound · 2022-03-03T09:53:53Z

...essment/question/programming/containers/ProgrammingQuestionForm/ProgrammingQuestionForm.scss

-  margin-right: 1em;
-  margin-top: 0.5em;
+  cursor: pointer !important;
+  margin-right: 1em !important;


!important should not be used

hound · 2022-03-03T09:53:53Z

...essment/question/programming/containers/ProgrammingQuestionForm/ProgrammingQuestionForm.scss

-  cursor: pointer;
-  margin-right: 1em;
-  margin-top: 0.5em;
+  cursor: pointer !important;


!important should not be used

ekowidianto · 2022-03-25T01:00:28Z

Closes https://github.com/Coursemology/coursemology2/security/dependabot/3 and https://github.com/Coursemology/coursemology2/security/dependabot/39 sequrity issues as node-fetch is no longer used in mui package

zhuhanming

I've been testing out the app over the past week - super solid work! I don't think there are any major issues. Code-wise, I've roughly looked through and it looks ok.

I'll list out issues that I've found / will find in a separate comment. @cysjonathan @lyskevin would appreciate your help in testing as well!

zhuhanming · 2022-03-25T01:53:55Z

Button positioning and margin bottom seems to have changed for forum post response
Rebase
Need to check that our theme, which is applied during building and deployment, still works for the new UI.
MUI datepicker - if you manually type in a date, then click the picker and click out, the date that was typed in gets resetted to the date before the manual typing (if there's no previous date, the field gets cleared).

Screen.Recording.2022-04-01.at.11.29.11.AM.mov
Loading spinners on some screens lack padding on top. I think lesson plan screen has the same issues.

…inline-block has been removed in v4

…agefile

zhuhanming

I think this looks good to go to me.

I've added more items to the list above, but they're minor nits - we should be able to deploy this.

ekowidianto · 2022-04-01T03:48:01Z

Loading spinners on some screens lack padding on top. I think lesson plan screen has the same issues.

This should have been fixed in this commit bd52e91

ekowidianto · 2022-04-01T04:02:34Z

MUI datepicker - if you manually type in a date, then click the picker and click out, the date that was typed in gets resetted to the date before the manual typing (if there's no previous date, the field gets cleared).

Seems like it's MUI's problem. See: mui/mui-x#4478

zhuhanming · 2022-04-01T04:07:10Z

Ok then let us merge this.

ekowidianto · 2022-04-01T04:12:49Z

Closes mui/material-ui#2438

hound bot reviewed Mar 3, 2022

View reviewed changes

ekowidianto changed the base branch from master to update-client-deps-2 March 3, 2022 09:53

ekowidianto mentioned this pull request Mar 4, 2022

[WIP] Update MUI to v5 #4363

Closed

4 tasks

Base automatically changed from update-client-deps-2 to master March 6, 2022 14:43

ekowidianto mentioned this pull request Mar 7, 2022

chore(mui update): update mui to v5 #4394

Merged

4 tasks

ekowidianto force-pushed the eko/upgrade-mui-rebased-clean branch from b89704b to 1efa5cb Compare March 14, 2022 01:44

ekowidianto requested a review from zhuhanming March 15, 2022 02:20

ekowidianto marked this pull request as ready for review March 15, 2022 02:24

ekowidianto force-pushed the eko/upgrade-mui-rebased-clean branch 3 times, most recently from b4684bd to 0714d3a Compare March 17, 2022 06:42

zhuhanming changed the title ~~Upgrade to MUI v3 - rebased from client-deps-2 upgrade~~ Upgrade to MUI v5 - rebased from client-deps-2 upgrade Mar 21, 2022

zhuhanming approved these changes Mar 25, 2022

View reviewed changes

ekowidianto force-pushed the eko/upgrade-mui-rebased-clean branch from 20afaf9 to 89f212e Compare March 25, 2022 06:58

ekowidianto added 14 commits March 28, 2022 19:46

chore(mui v3 update): update mui to v3

d6f16c6

chore(group): update mui components for group feature to v3

1de108f

fix(notification bar): add react memo to replace shouldcomponentupdate

289adfb

chore(mui v3 update): update mui to v3

d90421b

chore(mui update): update mui to v4

c963243

chore(mui v4 update): remove black and white color import from mui

7465294

chore(mui v4 update): update mui theme config

15ffe3f

chore(mui v4 update): update nativecolor to htmlcolor for mui icons

15f4a0c

chore(mui v4 update): update left margin for mui redux toggle component

67ee55b

chore(mui v4 update): update default styles for several mui components

308235f

test(mui v4 update): fix failing frontend tests after mui v4 update

05b9c73

chore(mui v4 update): update slider to use mui v4

6333e01

fix(video): fix proptypes for captionsstate

b93026d

chore(mui v4 update): update display method for card header props as …

4287524

…inline-block has been removed in v4

ekowidianto added 21 commits March 28, 2022 19:46

chore(mui v5 upgrade): update mui accordion component

278b047

chore(mui v5 upgrade): update mui tabs component

36298a3

chore(mui v5 upgrade): update mui switch component

3d3ee56

chore(mui v5 upgrade): update mui menu and menu item components

6bf0537

chore(mui v5 upgrade): update mui formcontrollabel component

74e0f9c

chore(mui v5 upgrade): update mui list component

f3da5b2

chore(mui v5 upgrade): update mui popover component

0099d14

chore(mui v5 upgrade): update mui iconbutton component

0a5f684

chore(mui v5 upgrade): update mui text field component

23e0185

chore(mui v5 upgrade): update mui toolbar and typography components

af7f1c0

chore(mui v5 upgrade): update mui button components

e471f8c

chore(mui v5 upgrade): update mui fab component

633edaf

test(mui v5 button): fix failing tests

cdb289c

fix(mui v5 upgrade): fix checked for button component in existingpack…

4632136

…agefile

chore(mui v5 upgrade): update mui date picker component

4773849

chore(mui v5 upgrade): update mui select and related components

02e072e

chore(mui v5 upgrade): remove mui v4

1ef09c0

test(mui v5 upgrade): disable circleci failing test

ab75bb2

chore(date io): remove obsolete date io moment lib

578aded

chore(mui v5 upgrade): minor styling fixes

bd52e91

fix(forum post qn): fix view forum and topic buttons location

808e64c

ekowidianto force-pushed the eko/upgrade-mui-rebased-clean branch from c168e03 to 808e64c Compare March 28, 2022 11:46

zhuhanming self-requested a review March 30, 2022 04:21

zhuhanming approved these changes Apr 1, 2022

View reviewed changes

zhuhanming merged commit 31a7a30 into master Apr 1, 2022

zhuhanming deleted the eko/upgrade-mui-rebased-clean branch April 1, 2022 04:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Upgrade to MUI v5 - rebased from client-deps-2 upgrade #4391

Upgrade to MUI v5 - rebased from client-deps-2 upgrade #4391

ekowidianto commented Mar 3, 2022 •

edited

Loading

hound bot Mar 3, 2022

hound bot Mar 3, 2022

hound bot Mar 3, 2022

hound bot Mar 3, 2022

ekowidianto commented Mar 25, 2022

zhuhanming left a comment

zhuhanming commented Mar 25, 2022 •

edited

Loading

zhuhanming left a comment

ekowidianto commented Apr 1, 2022

ekowidianto commented Apr 1, 2022

zhuhanming commented Apr 1, 2022

ekowidianto commented Apr 1, 2022 •

edited

Loading

Upgrade to MUI v5 - rebased from client-deps-2 upgrade #4391

Upgrade to MUI v5 - rebased from client-deps-2 upgrade #4391

Conversation

ekowidianto commented Mar 3, 2022 • edited Loading

hound bot Mar 3, 2022

Choose a reason for hiding this comment

hound bot Mar 3, 2022

Choose a reason for hiding this comment

hound bot Mar 3, 2022

Choose a reason for hiding this comment

hound bot Mar 3, 2022

Choose a reason for hiding this comment

ekowidianto commented Mar 25, 2022

zhuhanming left a comment

Choose a reason for hiding this comment

zhuhanming commented Mar 25, 2022 • edited Loading

zhuhanming left a comment

Choose a reason for hiding this comment

ekowidianto commented Apr 1, 2022

ekowidianto commented Apr 1, 2022

zhuhanming commented Apr 1, 2022

ekowidianto commented Apr 1, 2022 • edited Loading

ekowidianto commented Mar 3, 2022 •

edited

Loading

zhuhanming commented Mar 25, 2022 •

edited

Loading

ekowidianto commented Apr 1, 2022 •

edited

Loading