v0.2 - python 3 compatibility #30
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wow this is awesome! @CurleySamuel are you going to merge this soon? If new life is breathed into the library, I'm willing to contribute as well. |
a lot of bytes/unicode mangling and updating protobufs decoder
python 2 compatibility -- %b doesnt exist in python2
fix byte/str encoding in exception classes
|
Is this going to be merged in the near future? I would be very interested in using PyBase |
|
@dandydev - feel free to use the https://github.com/Flipboard/PyBase fork - We're using it in production so will be keeping it up to date. I'll happily review PRs if you have them |
|
@sjhewitt that's great! Any plans to publish the package on PyPI, with proper versioning etc.? Maybe as |
Add zk watch for master connection
Make py2 compatible plus remove some dead code
Fix bytes string host
* use native str for region_client exceptions * minor cleanup * try enforcing unicode elsewhere * test log * use unicode host * remove test log, fix last flake8 warning
…lExecutor using a ThreadPoolExecutor to match socket pool
Add support for `get_many`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.