#1602: CMake: set warning flags first

DARMA-tasking · Nov 18, 2021 · 582ed9b · 582ed9b
1 parent 9cff903
commit 582ed9b
Show file tree

Hide file tree

Showing 4 changed files with 7 additions and 5 deletions.
diff --git a/cmake-modules/SetCXXCompilerFlags.cmake b/cmake-modules/SetCXXCompilerFlags.cmake
@@ -39,6 +39,6 @@ if (vt_ubsan_enabled)
 endif()
 
 message(DEBUG "Target ${vt_target} compile options: ${TARGET_CXX_FLAGS}")
-target_compile_options(${vt_target} PUBLIC ${TARGET_CXX_FLAGS})
+target_compile_options(${vt_target} PUBLIC ${TARGET_CXX_FLAGS}) # PRIVATE?
 
 endmacro()
diff --git a/cmake/turn_on_warnings.cmake b/cmake/turn_on_warnings.cmake
@@ -3,7 +3,7 @@ include(CheckCXXCompilerFlag)
 function(enable_cxx_compiler_flag_if_supported flag)
   check_cxx_compiler_flag("${flag}" flag_supported)
   if(flag_supported)
-    target_compile_options(${vt_target} PUBLIC ${flag})
+    target_compile_options(${vt_target} PUBLIC ${flag}) # PRIVATE?
   endif()
   unset(flag_supported CACHE)
 endfunction()

diff --git a/examples/CMakeLists.txt b/examples/CMakeLists.txt
@@ -18,6 +18,8 @@ macro(add_example example_name)
     set_target_properties(${example_name} PROPERTIES UNITY_BUILD ON)
   endif()
 
+  # compiler flags / warnings
+
   link_target_with_vt(
     TARGET ${example_name}
     DEFAULT_LINK_SET

diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
@@ -231,12 +231,12 @@ target_compile_features(
   cxx_alias_templates
 )
 
-include(SetCXXCompilerFlags)
-set_darma_compiler_flags(${VIRTUAL_TRANSPORT_LIBRARY})
-
 include(turn_on_warnings)
 turn_on_warnings(${VIRTUAL_TRANSPORT_LIBRARY})
 
+include(SetCXXCompilerFlags)
+set_darma_compiler_flags(${VIRTUAL_TRANSPORT_LIBRARY})
+
 if (vt_gold_linker_enabled)
   if (UNIX AND NOT APPLE)
     execute_process(