Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop using CMAKE_CXX_FLAGS for setting compile options #1602

Closed
cz4rs opened this issue Nov 5, 2021 · 0 comments · Fixed by #1613
Closed

stop using CMAKE_CXX_FLAGS for setting compile options #1602

cz4rs opened this issue Nov 5, 2021 · 0 comments · Fixed by #1613
Assignees
@cz4rs
Labels
pri: normal type: task

Comments

@cz4rs
Copy link
Contributor

cz4rs commented Nov 5, 2021

What Needs to be Done?
Specify compile options per target instead of using global CMAKE_CXX_FLAGS variable (see cmake-modules/SetCXXCompilerFlags.cmake as the main offender).

Preferred solution is to use target_compile_options command (which can specify INTERFACE|PUBLIC|PRIVATE keywords).

Is your feature request related to a problem? Please describe.
Using CMAKE_CXX_FLAGS can affect applications built on top of vt.
@cz4rs cz4rs self-assigned this Nov 5, 2021
@cz4rs cz4rs mentioned this issue Nov 5, 2021
Merged
@lifflander lifflander mentioned this issue Nov 9, 2021
Open
cz4rs added a commit that referenced this issue Nov 12, 2021
@cz4rs
#1602: CMake: remove obsolete variable
1c09633
cz4rs added a commit that referenced this issue Nov 15, 2021
@cz4rs
#1602: CMake: remove obsolete variable
31024b4
cz4rs added a commit that referenced this issue Nov 15, 2021
@cz4rs
#1602: handle warning-related options in one place
9ca910a
cz4rs added a commit that referenced this issue Nov 17, 2021
@cz4rs
#1602: CMake: remove obsolete variable
970c13d
cz4rs added a commit that referenced this issue Nov 17, 2021
@cz4rs
#1602: handle warning-related options in one place
9ce2d0e
cz4rs added a commit that referenced this issue Nov 17, 2021
@cz4rs
#1602: use target_compile_options to set compilation flags
ea8ea4c
@cz4rs cz4rs mentioned this issue Nov 17, 2021
Merged
cz4rs added a commit that referenced this issue Nov 17, 2021
@cz4rs
#1602: make version checking more concise
6977d88
cz4rs added a commit that referenced this issue Nov 17, 2021
@cz4rs
#1602: CMake: clean up configuration printing
3d4b876
cz4rs added a commit that referenced this issue Nov 18, 2021
@cz4rs
#1602: use target_compile_options for enabling warnings
0a3c7f1
cz4rs added a commit that referenced this issue Nov 18, 2021
@cz4rs
#1602: remove obsolete scripts
9cff903
cz4rs added a commit that referenced this issue Nov 18, 2021
@cz4rs
#1602: CMake: set warning flags first
582ed9b
cz4rs added a commit that referenced this issue Nov 19, 2021
@cz4rs
#1602: CMake: remove obsolete variable
250b0a0
cz4rs added a commit that referenced this issue Nov 19, 2021
@cz4rs
#1602: handle warning-related options in one place
cf54514
cz4rs added a commit that referenced this issue Nov 19, 2021
@cz4rs
#1602: use target_compile_options to set compilation flags
9efb9a1
cz4rs added a commit that referenced this issue Nov 19, 2021
@cz4rs
#1602: make version checking more concise
172eb06
cz4rs added a commit that referenced this issue Nov 19, 2021
@cz4rs
#1602: CMake: clean up configuration printing
4503716
cz4rs added a commit that referenced this issue Nov 19, 2021
@cz4rs
#1602: use target_compile_options for enabling warnings
0afee54
cz4rs added a commit that referenced this issue Nov 19, 2021
@cz4rs
#1602: remove obsolete scripts
1f5abb7
cz4rs added a commit that referenced this issue Nov 19, 2021
@cz4rs
#1602: CMake: set warning flags first
c076fe5
cz4rs added a commit that referenced this issue Nov 19, 2021
@cz4rs
#1602: use PRIVATE (?)
93bc874
cz4rs added a commit that referenced this issue Nov 19, 2021
@cz4rs
#1602: CMake: disable compiler specific C++ extensions
34b2276
cz4rs added a commit that referenced this issue Nov 19, 2021
@cz4rs
#1602: CMake: disable compiler specific C++ extensions
142d754
cz4rs added a commit that referenced this issue Nov 19, 2021
@cz4rs
#1602: CMake: mark added compilation flags as private
fe05d96
cz4rs added a commit that referenced this issue Nov 19, 2021
@cz4rs
#1602: CMake: mark added compilation flags as private
c10ce38
cz4rs added a commit that referenced this issue Nov 23, 2021
@cz4rs
#1602: CMake: remove obsolete variable
3b4daa1
cz4rs added a commit that referenced this issue Nov 23, 2021
@cz4rs
#1602: handle warning-related options in one place
300760f
cz4rs added a commit that referenced this issue Nov 23, 2021
@cz4rs
#1602: use target_compile_options to set compilation flags
6c8d891
cz4rs added a commit that referenced this issue Nov 23, 2021
@cz4rs
#1602: make version checking more concise
d3dde2a
cz4rs added a commit that referenced this issue Nov 23, 2021
@cz4rs
#1602: CMake: clean up configuration printing
7dd2246
cz4rs added a commit that referenced this issue Nov 23, 2021
@cz4rs
#1602: use target_compile_options for enabling warnings
0c3584b
cz4rs added a commit that referenced this issue Nov 23, 2021
@cz4rs
#1602: remove obsolete scripts
fbfa207
cz4rs added a commit that referenced this issue Nov 23, 2021
@cz4rs
#1602: CMake: set warning flags first
26641fc
cz4rs added a commit that referenced this issue Nov 23, 2021
@cz4rs
#1602: CMake: disable compiler specific C++ extensions
b0c859f
cz4rs added a commit that referenced this issue Nov 23, 2021
@cz4rs
#1602: CMake: mark added compilation flags as private
bbb60c6
cz4rs added a commit that referenced this issue Nov 23, 2021
@cz4rs
#1602: CMake: stop checking for parent when enabling warnings
ba10c44
cz4rs added a commit that referenced this issue Nov 23, 2021
@cz4rs
#1602: CMake: use PUBLIC for flags that should impact dependent projects
ee8e1a2
cz4rs added a commit that referenced this issue Nov 23, 2021
@cz4rs
#1602: CMake: enable warnings in tests and examples
850bad8
cz4rs added a commit that referenced this issue Nov 23, 2021
@cz4rs
#1602: CMake: handle warning related options in one place
f41a3cc
cz4rs added a commit that referenced this issue Nov 23, 2021
@cz4rs
#1602: CMake: remove obsolete variable
bfb20e8
cz4rs added a commit that referenced this issue Nov 23, 2021
@cz4rs
#1602: handle warning-related options in one place
c2c24c3
cz4rs added a commit that referenced this issue Nov 23, 2021
@cz4rs
#1602: use target_compile_options to set compilation flags
196d245
cz4rs added a commit that referenced this issue Nov 23, 2021
@cz4rs
#1602: make version checking more concise
05e43bc
cz4rs added a commit that referenced this issue Nov 23, 2021
@cz4rs
#1602: CMake: clean up configuration printing
d8cb1e7
cz4rs added a commit that referenced this issue Nov 23, 2021
@cz4rs
#1602: use target_compile_options for enabling warnings
2be3b00
cz4rs added a commit that referenced this issue Nov 23, 2021
@cz4rs
#1602: remove obsolete scripts
bb9e0a5
cz4rs added a commit that referenced this issue Nov 23, 2021
@cz4rs
#1602: CMake: set warning flags first
0d451f6
cz4rs added a commit that referenced this issue Nov 23, 2021
@cz4rs
#1602: CMake: disable compiler specific C++ extensions
10eda7b
cz4rs added a commit that referenced this issue Nov 23, 2021
@cz4rs
#1602: CMake: mark added compilation flags as private
8c0b6f5
cz4rs added a commit that referenced this issue Nov 23, 2021
@cz4rs
#1602: CMake: stop checking for parent when enabling warnings
19dfa35
cz4rs added a commit that referenced this issue Nov 23, 2021
@cz4rs
#1602: CMake: use PUBLIC for flags that should impact dependent projects
98666b0
cz4rs added a commit that referenced this issue Nov 23, 2021
@cz4rs
#1602: CMake: enable warnings in tests and examples
419599e
cz4rs added a commit that referenced this issue Nov 23, 2021
@cz4rs
#1602: CMake: handle warning related options in one place
e851266
cz4rs added a commit that referenced this issue Nov 24, 2021
@cz4rs
Merge pull request #1613 from DARMA-tasking/1602-refactor-cmake-compi…
a4da5db 
…ler-flags

#1602: stop using CMAKE_CXX_FLAGS for setting compile options
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cz4rs cz4rs

Labels
pri: normal type: task
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1602: stop using CMAKE_CXX_FLAGS for setting compile options DARMA-tasking/vt
1 participant
@cz4rs