#1602: handle warning-related options in one place

DARMA-tasking · Nov 17, 2021 · 9ce2d0e · 9ce2d0e
1 parent 970c13d
commit 9ce2d0e
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -90,11 +90,7 @@ option(vt_mimalloc_enabled "Build VT with mimalloc" OFF)
 option(vt_mimalloc_static "Build VT with mimalloc using static linking" ON)
 option(vt_asan_enabled "Build VT with address sanitizer" OFF)
 option(vt_ubsan_enabled "Build VT with undefined behavior sanitizer" OFF)
-
 option(vt_werror_enabled "Build VT with -Werror enabled" OFF)
-if (vt_werror_enabled)
-  enable_cxx_compiler_flag_if_supported("-Werror")
-endif()
 
 include(cmake/nvcc_no_deprecated_gpu_targets.cmake)
 include(cmake/load_bundled_libraries.cmake)

diff --git a/cmake/turn_on_warnings.cmake b/cmake/turn_on_warnings.cmake
@@ -19,4 +19,8 @@ if(NOT hasParent)
   enable_cxx_compiler_flag_if_supported("-Wsign-compare")
   # Not really a warning, is still diagnostic related..
   enable_cxx_compiler_flag_if_supported("-ftemplate-backtrace-limit=100")
+
+  if (vt_werror_enabled)   # Treat warning as errors
+    enable_cxx_compiler_flag_if_supported("-Werror")
+  endif()
 endif()