Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"warning: comparison of unsigned expression >= 0 is always true" #1054

Closed
pnstickne opened this issue Sep 15, 2020 · 1 comment · Fixed by #1082
Closed

"warning: comparison of unsigned expression >= 0 is always true" #1054

pnstickne opened this issue Sep 15, 2020 · 1 comment · Fixed by #1082
Assignees
@PhilMiller
Labels
type: bug

Comments

@pnstickne
Copy link
Contributor

pnstickne commented Sep 15, 2020 •
edited
Loading 

vt/vrt/collection/balance/node_stats.cc:145:25: warning: comparison of unsigned expression >= 0 is always true [-Wtautological-compare]
  if (phase - look_back >= 0) {
@PhilMiller PhilMiller self-assigned this Sep 23, 2020
PhilMiller added a commit that referenced this issue Sep 23, 2020
@PhilMiller
#1054: Fix inadvertently tautological comparison
2977a0e
@PhilMiller PhilMiller mentioned this issue Sep 23, 2020
Merged
PhilMiller added a commit that referenced this issue Sep 23, 2020
@PhilMiller
#1054: Fix inadvertently tautological comparison
64b759c
lifflander pushed a commit that referenced this issue Sep 24, 2020
@PhilMiller @lifflander
#1054: Fix inadvertently tautological comparison
22bacbb
@PhilMiller
Copy link
Member

The fix for this brought up #1099 as result.

bradybray pushed a commit that referenced this issue Oct 13, 2020
@PhilMiller
#1054: Fix inadvertently tautological comparison
356e65f
bradybray pushed a commit that referenced this issue Oct 15, 2020
@PhilMiller
#1054: Fix inadvertently tautological comparison
f168f7d
bradybray pushed a commit that referenced this issue Oct 15, 2020
@PhilMiller
#1054: Fix inadvertently tautological comparison
2db51e6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhilMiller PhilMiller

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

1054 Fix inadvertently tautological comparison DARMA-tasking/vt
2 participants
@PhilMiller @pnstickne