Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning comparing signed/unsigned in NodeStats #1099

Closed
lifflander opened this issue Sep 29, 2020 · 1 comment · Fixed by #1101
Closed

Warning comparing signed/unsigned in NodeStats #1099

lifflander opened this issue Sep 29, 2020 · 1 comment · Fixed by #1101
Assignees
@PhilMiller
Labels
type: bug

Comments

@lifflander
Copy link
Collaborator

Describe the bug
#1082 tried to fix the bug generates a warning about comparing signed and unsigned.
@PhilMiller PhilMiller mentioned this issue Sep 29, 2020
Closed
@PhilMiller
Copy link
Member

look_back should perhaps just be unsigned, since it should never be negative, and doesn't need a sentinel value.

PhilMiller added a commit that referenced this issue Sep 29, 2020
@PhilMiller
#1099: Count phases as unsigned and avoid mixed arithmetic/comparisons
3a48e8a
@PhilMiller PhilMiller mentioned this issue Sep 29, 2020
Merged
lifflander added a commit that referenced this issue Sep 30, 2020
@lifflander
Merge pull request #1101 from DARMA-tasking/1099-lookback
bee61ce 
#1099: Count phases as unsigned and avoid mixed arithmetic/comparisons
bradybray pushed a commit that referenced this issue Oct 13, 2020
@PhilMiller
#1099: Count phases as unsigned and avoid mixed arithmetic/comparisons
96ace6c
bradybray pushed a commit that referenced this issue Oct 15, 2020
@PhilMiller
#1099: Count phases as unsigned and avoid mixed arithmetic/comparisons
33c6cd7
bradybray pushed a commit that referenced this issue Oct 15, 2020
@PhilMiller
#1099: Count phases as unsigned and avoid mixed arithmetic/comparisons
7eee4aa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhilMiller PhilMiller

Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#1099: Count phases as unsigned and avoid mixed arithmetic/comparisons DARMA-tasking/vt
2 participants
@PhilMiller @lifflander