Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop polluting std namespace with using declarations #1452

Closed
nlslatt opened this issue May 26, 2021 · 1 comment · Fixed by #1651
Closed

Stop polluting std namespace with using declarations #1452

nlslatt opened this issue May 26, 2021 · 1 comment · Fixed by #1651

Comments

@nlslatt
Copy link
Collaborator

nlslatt commented May 26, 2021

What Needs to be Done?
Use fully qualified names when defining hash functions and other stuff within std namespace instead of adding using declarations that pollute the std namespace.

@lifflander
Copy link
Collaborator

These seem to be the offending cases referred to in this issue.

--
src/vt/rdma/channel/rdma_channel_lookup.h:namespace std {
src/vt/rdma/channel/rdma_channel_lookup.h-  using RDMA_ChannelLookupType = vt::rdma::ChannelLookup;
src/vt/rdma/channel/rdma_channel_lookup.h-
--
src/vt/utils/memory/memory_units.h:namespace std {
src/vt/utils/memory/memory_units.h-
src/vt/utils/memory/memory_units.h-using MemoryUnitType = vt::util::memory::MemoryUnitEnum;
--
src/vt/vrt/collection/balance/lb_comm.h:namespace std {
src/vt/vrt/collection/balance/lb_comm.h-
src/vt/vrt/collection/balance/lb_comm.h-using CommCategoryType    = vt::vrt::collection::balance::CommCategory;
--
src/vt/vrt/collection/balance/lb_common.h:namespace std {
src/vt/vrt/collection/balance/lb_common.h-
src/vt/vrt/collection/balance/lb_common.h-using StatisticType = vt::vrt::collection::lb::Statistic;
--
src/vt/vrt/collection/balance/lb_common.h:namespace std {
src/vt/vrt/collection/balance/lb_common.h-
src/vt/vrt/collection/balance/lb_common.h-using ElementIDStructType = vt::vrt::collection::balance::ElementIDStruct;
--
src/vt/vrt/collection/balance/lb_type.h:namespace std {
src/vt/vrt/collection/balance/lb_type.h-
src/vt/vrt/collection/balance/lb_type.h-using LBTypeType = vt::vrt::collection::balance::LBType;
--

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants