1376 improve lbargs for gossiplb #1422

nlslatt · 2021-05-03T19:34:14Z

Makes LB args for GossipLB more human readable, improves error handling, adds the (default) ability to have vt choose an appropriate fanout and number of gossiping rounds, makes asynchronous informs the default, and sets the number of trials to 1 (more lightweight) by default.

Closes #1376.

github-actions · 2021-05-03T19:38:04Z

PR tests (gcc-5, ubuntu, mpich)

Build for feba7b7

Compilation - successful

Testing - passed

Build log

github-actions · 2021-05-03T19:41:56Z

PR tests (gcc-10, ubuntu, openmpi, no LB)

Build for feba7b7

Compilation - successful

Testing - passed

Build log

github-actions · 2021-05-03T19:49:00Z

PR tests (nvidia cuda 11.0, ubuntu, mpich)

Build for feba7b7

Compilation - successful

Testing - passed

Build log

github-actions · 2021-05-03T20:00:38Z

PR tests (gcc-7, ubuntu, mpich, trace runtime, LB)

Build for feba7b7

Compilation - successful

Testing - passed

Build log

src/vt/vrt/collection/balance/gossiplb/gossiplb.cc

github-actions · 2021-05-03T20:33:30Z

PR tests (gcc-6, ubuntu, mpich)

Build for feba7b7

Compilation - successful

Testing - passed

Build log

github-actions · 2021-05-03T20:35:39Z

PR tests (clang-3.9, ubuntu, mpich)

Build for feba7b7

Compilation - successful

Testing - passed

Build log

github-actions · 2021-05-03T20:38:20Z

PR tests (clang-5.0, ubuntu, mpich)

Build for feba7b7

Compilation - successful

Testing - passed

Build log

github-actions · 2021-05-03T20:43:02Z

PR tests (gcc-9, ubuntu, mpich, zoltan)

Build for feba7b7

Compilation - successful

Testing - passed

Build log

github-actions · 2021-05-03T20:43:20Z

PR tests (gcc-8, ubuntu, mpich, address sanitizer)

Build for feba7b7

Compilation - successful

Testing - passed

Build log

github-actions · 2021-05-03T21:46:53Z

PR tests (intel 19, ubuntu, mpich)

Build for feba7b7

Compilation - successful

Testing - passed

Build log

github-actions · 2021-05-03T21:48:00Z

PR tests (nvidia cuda 10.1, ubuntu, mpich)

Build for feba7b7

Compilation - successful

Testing - passed

Build log

github-actions · 2021-05-03T21:53:52Z

PR tests (clang-9, ubuntu, mpich)

Build for feba7b7

Compilation - successful

Testing - passed

Build log

github-actions · 2021-05-03T21:54:03Z

PR tests (intel 18.03, ubuntu, mpich)

Build for feba7b7

Compilation - successful

Testing - passed

Build log

github-actions · 2021-05-03T22:07:18Z

PR tests (clang-8, alpine, mpich)

Build for 2e5a7be



The following tests FAILED:
  488 - vt:*/TestSequencerExtensive.test_wait_1/*_proc_2 (Timeout)

Build log

github-actions · 2021-05-03T22:07:25Z

PR tests (clang-10, ubuntu, mpich)

Build for feba7b7

Compilation - successful

Testing - passed

Build log

github-actions · 2021-05-11T18:32:19Z

PR tests (clang-10, alpine, mpich)

Build for feba7b7

Compilation - successful

Testing - passed

Build log

codecov · 2021-05-11T18:52:49Z

Codecov Report

Merging #1422 (8fa1feb) into develop (145a258) will decrease coverage by 0.09%.
The diff coverage is 80.85%.

❗ Current head 8fa1feb differs from pull request most recent head feba7b7. Consider uploading reports for the commit feba7b7 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1422      +/-   ##
===========================================
- Coverage    82.86%   82.76%   -0.10%     
===========================================
  Files          760      760              
  Lines        28736    28780      +44     
===========================================
+ Hits         23811    23821      +10     
- Misses        4925     4959      +34

Impacted Files	Coverage Δ
src/vt/vrt/collection/balance/gossiplb/gossiplb.h	`100.00% <ø> (ø)`
src/vt/vrt/collection/balance/gossiplb/gossiplb.cc	`68.73% <69.56%> (-2.18%)`	⬇️
.../vt/vrt/collection/balance/gossiplb/gossip_enums.h	`86.66% <86.66%> (ø)`
tests/unit/collection/test_lb.extended.cc	`86.84% <100.00%> (-0.34%)`	⬇️
tests/unit/lb/test_gossiplb.nompi.cc	`100.00% <100.00%> (ø)`
src/vt/configs/error/error.impl.h	`0.00% <0.00%> (-100.00%)`	⬇️
src/vt/termination/dijkstra-scholten/comm.cc	`54.54% <0.00%> (-12.73%)`	⬇️
src/vt/topos/location/location.impl.h	`90.49% <0.00%> (-3.69%)`	⬇️
src/vt/collective/collective_ops.cc	`56.00% <0.00%> (-3.62%)`	⬇️
... and 13 more

nlslatt · 2021-05-24T19:25:39Z

@lifflander @PhilMiller This still needs to be reviewed.

tests/unit/collection/test_lb.extended.cc

src/vt/vrt/collection/balance/lb_args_enum_converter.h

nlslatt requested review from PhilMiller, lifflander, cz4rs, nmm0, JacobDomagala and jstrzebonski May 3, 2021 19:34

nlslatt commented May 3, 2021

View reviewed changes

src/vt/vrt/collection/balance/gossiplb/gossiplb.cc Outdated Show resolved Hide resolved

lifflander mentioned this pull request May 4, 2021

Meeting Agenda [do not close] #925

Open

nlslatt mentioned this pull request May 4, 2021

1410 GossipLB: Select candidate migrant object, and then exclude ineligible recipient nodes #1421

Merged

nlslatt force-pushed the 1376-improve-lbargs-for-gossiplb branch from 2e5a7be to e266e48 Compare May 11, 2021 18:16

nlslatt marked this pull request as ready for review May 17, 2021 22:08

PhilMiller reviewed May 25, 2021

View reviewed changes

tests/unit/collection/test_lb.extended.cc Outdated Show resolved Hide resolved

nlslatt added 20 commits May 28, 2021 10:29

#1376: gossiplb: default to async informs

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

6869f89

#1376: gossiplb: default to only one trial

f4b54ac

#1376: gossiplb: omit migrations from terse output

4fc9fb5

#1376: gossiplb: use true bools for bool lb args

a302101

#1376: gossiplb: improve error messages

bf8900f

#1376: gossiplb: removes unused default values

466957f

#1376: tests: update lb args for test

72d12b1

#1376: gossiplb: add hash for enums

513a772

#1376: gossiplb: fix for serial load balancing tests

1b07d35

#1376: gossiplb: define hash for criterion enum

a3b34b6

#1376: gossiplb: stop polluting std namespace

3f27cc5

#1376: tests: clean up setting lb args

9138c9c

#1376: tests: test enum converter

521989d

#1376: gossiplb: clean up types

21d861d

#1376: gossiplb: document enum converter

ca84c8a

#1376: gossiplb: additional doxygen for enum converter

a2c9bcf

#1376: gossiplb: rename enum converter

c304a07

#1376: gossiplb: move enum converter out of gossiplb

f759b60

#1376: tests: split off lb args enum converter tests

b651487

#1376: tests: add spec-related to enum conversion

e691572

JacobDomagala mentioned this pull request May 28, 2021

1456: Change vt_throw_on_abort to runtime flag #1457

Merged

#1376: tests: add throw tests for enum conversion

47989b1

nlslatt force-pushed the 1376-improve-lbargs-for-gossiplb branch from 3c0b43f to 47989b1 Compare May 28, 2021 17:38

#1456: config: remove throw_on_abort from feature list

af88059

lifflander approved these changes May 28, 2021

View reviewed changes

src/vt/vrt/collection/balance/lb_args_enum_converter.h Show resolved Hide resolved

#1376: balance: make data members private

feba7b7

JacobDomagala approved these changes May 28, 2021

View reviewed changes

nlslatt merged commit f5a0e83 into develop May 28, 2021

cz4rs mentioned this pull request Jun 15, 2021

move vt version number into a separate file #1467

Closed

7 tasks

cz4rs mentioned this pull request Dec 21, 2021

1637: create 1.1.1 Beta v6 release candidate #1638

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1376 improve lbargs for gossiplb #1422

1376 improve lbargs for gossiplb #1422

nlslatt commented May 3, 2021

github-actions bot commented May 3, 2021 •

edited

Loading

github-actions bot commented May 3, 2021 •

edited

Loading

github-actions bot commented May 3, 2021 •

edited

Loading

github-actions bot commented May 3, 2021 •

edited

Loading

github-actions bot commented May 3, 2021 •

edited

Loading

github-actions bot commented May 3, 2021 •

edited

Loading

github-actions bot commented May 3, 2021 •

edited

Loading

github-actions bot commented May 3, 2021 •

edited

Loading

github-actions bot commented May 3, 2021 •

edited

Loading

github-actions bot commented May 3, 2021 •

edited

Loading

github-actions bot commented May 3, 2021 •

edited

Loading

github-actions bot commented May 3, 2021 •

edited

Loading

github-actions bot commented May 3, 2021 •

edited

Loading

github-actions bot commented May 3, 2021

github-actions bot commented May 3, 2021 •

edited

Loading

github-actions bot commented May 11, 2021 •

edited

Loading

codecov bot commented May 11, 2021 •

edited

Loading

nlslatt commented May 24, 2021

1376 improve lbargs for gossiplb #1422

1376 improve lbargs for gossiplb #1422

Conversation

nlslatt commented May 3, 2021

github-actions bot commented May 3, 2021 • edited Loading

github-actions bot commented May 3, 2021 • edited Loading

github-actions bot commented May 3, 2021 • edited Loading

github-actions bot commented May 3, 2021 • edited Loading

github-actions bot commented May 3, 2021 • edited Loading

github-actions bot commented May 3, 2021 • edited Loading

github-actions bot commented May 3, 2021 • edited Loading

github-actions bot commented May 3, 2021 • edited Loading

github-actions bot commented May 3, 2021 • edited Loading

github-actions bot commented May 3, 2021 • edited Loading

github-actions bot commented May 3, 2021 • edited Loading

github-actions bot commented May 3, 2021 • edited Loading

github-actions bot commented May 3, 2021 • edited Loading

github-actions bot commented May 3, 2021

github-actions bot commented May 3, 2021 • edited Loading

github-actions bot commented May 11, 2021 • edited Loading

codecov bot commented May 11, 2021 • edited Loading

Codecov Report

nlslatt commented May 24, 2021

github-actions bot commented May 3, 2021 •

edited

Loading

github-actions bot commented May 3, 2021 •

edited

Loading

github-actions bot commented May 3, 2021 •

edited

Loading

github-actions bot commented May 3, 2021 •

edited

Loading

github-actions bot commented May 3, 2021 •

edited

Loading

github-actions bot commented May 3, 2021 •

edited

Loading

github-actions bot commented May 3, 2021 •

edited

Loading

github-actions bot commented May 3, 2021 •

edited

Loading

github-actions bot commented May 3, 2021 •

edited

Loading

github-actions bot commented May 3, 2021 •

edited

Loading

github-actions bot commented May 3, 2021 •

edited

Loading

github-actions bot commented May 3, 2021 •

edited

Loading

github-actions bot commented May 3, 2021 •

edited

Loading

github-actions bot commented May 3, 2021 •

edited

Loading

github-actions bot commented May 11, 2021 •

edited

Loading

codecov bot commented May 11, 2021 •

edited

Loading